You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by mateiz <gi...@git.apache.org> on 2014/07/29 04:43:09 UTC

[GitHub] spark pull request: SPARK-2134: Report metrics before application ...

Github user mateiz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1076#discussion_r15503634
  
    --- Diff: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala ---
    @@ -91,6 +91,10 @@ private[spark] class MetricsSystem private (val instance: String,
         sinks.foreach(_.stop)
       }
     
    +  def report() {
    +    sinks.foreach(_.report)
    --- End diff --
    
    Make this say _.report() instead since report has side-effects


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---