You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "Codeprh (via GitHub)" <gi...@apache.org> on 2023/07/17 06:28:41 UTC
[PR] [ISSUE #4199] Catch Exception instead of Throwable (eventmesh)
Codeprh opened a new pull request, #4234:
URL: https://github.com/apache/eventmesh/pull/4234
Fixes [#4199](https://github.com/apache/eventmesh/issues/4199).
### Motivation
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/service/EventEmitter.java line 37,45,53
Use `Exception` instead of `Throwable`.
### Modifications
Use `Exception` instead of `Throwable`.
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4199] Catch Exception instead of Throwable (eventmesh)
Posted by "Codeprh (via GitHub)" <gi...@apache.org>.
Codeprh commented on code in PR #4234:
URL: https://github.com/apache/eventmesh/pull/4234#discussion_r1264959311
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/service/EventEmitter.java:
##########
@@ -18,8 +18,6 @@
package org.apache.eventmesh.runtime.core.protocol.grpc.service;
import io.grpc.stub.StreamObserver;
-
Review Comment:
ok,3q
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4199] Catch Exception instead of Throwable (eventmesh)
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #4234:
URL: https://github.com/apache/eventmesh/pull/4234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4199] Catch Exception instead of Throwable (eventmesh)
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on code in PR #4234:
URL: https://github.com/apache/eventmesh/pull/4234#discussion_r1264934828
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/service/EventEmitter.java:
##########
@@ -18,8 +18,6 @@
package org.apache.eventmesh.runtime.core.protocol.grpc.service;
import io.grpc.stub.StreamObserver;
-
Review Comment:
The two imports need to be separated by a blank line as required by checkstyle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4199] Catch Exception instead of Throwable (eventmesh)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4234:
URL: https://github.com/apache/eventmesh/pull/4234#issuecomment-1637527975
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4234?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4234](https://app.codecov.io/gh/apache/eventmesh/pull/4234?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (295b911) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/c5357d698ad72bef1c0abcaabf81e75153023db8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c5357d6) will **decrease** coverage by `0.03%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 295b911 differs from pull request most recent head e2992b5. Consider uploading reports for the commit e2992b5 to get more accurate results
```diff
@@ Coverage Diff @@
## master #4234 +/- ##
============================================
- Coverage 16.90% 16.88% -0.03%
+ Complexity 1416 1415 -1
============================================
Files 589 589
Lines 25837 25833 -4
Branches 2394 2392 -2
============================================
- Hits 4369 4363 -6
+ Misses 21031 21030 -1
- Partials 437 440 +3
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/4234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ntime/core/protocol/grpc/service/EventEmitter.java](https://app.codecov.io/gh/apache/eventmesh/pull/4234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9zZXJ2aWNlL0V2ZW50RW1pdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/4234/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org