You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/06/15 20:33:52 UTC

[GitHub] [arrow-datafusion] alamb opened a new pull request, #6690: Move `PartitonEvaluator` and window_state structures to `datafusion_expr` crate

alamb opened a new pull request, #6690:
URL: https://github.com/apache/arrow-datafusion/pull/6690

   
   # Which issue does this PR close?
   
   Part of #5781 
   
   
   # Rationale for this change
   
   We are in the process of allowing users to define their own window functions, and to do we plan for them to implement the `PartitionEvaluator` trait, similarly to how they implement the `Accumulator` trait for aggregates
   
   You can see the basic idea in the RFC PR: #6617 
   
   I think this is the last "getting ready" PR and the next one will have real support for User Defined Window Functions 🤞 
   
   # What changes are included in this PR?
   
   Move `PartitionEvaluator` and related structures to `datafusion_expr` crate (where the WindowUDFs will be defined)
   
   There is no new functionality, this PR just moves code around. 
   
   # Are these changes tested?
   
   Covered by existing tests
   
   # Are there any user-facing changes?
   `PartitionEvaluator` and related structs are now visible in `datafusion_expr`
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #6690: Move `PartitionEvaluator` and window_state structures to `datafusion_expr` crate

Posted by "alamb (via GitHub)" <gi...@apache.org>.

alamb commented on PR #6690:
URL: https://github.com/apache/arrow-datafusion/pull/6690#issuecomment-1599413760

   @mustafasrepo  I wonder if I can trouble you for a review of this PR? I think it is straightforward


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] mustafasrepo merged pull request #6690: Move `PartitionEvaluator` and window_state structures to `datafusion_expr` crate

Posted by "mustafasrepo (via GitHub)" <gi...@apache.org>.

mustafasrepo merged PR #6690:
URL: https://github.com/apache/arrow-datafusion/pull/6690


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org