You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Simon Lessard (JIRA)" <de...@myfaces.apache.org> on 2008/08/28 15:41:44 UTC
[jira] Created: (TRINIDAD-1201) Cleanup the skinning code
Cleanup the skinning code
-------------------------
Key: TRINIDAD-1201
URL: https://issues.apache.org/jira/browse/TRINIDAD-1201
Project: MyFaces Trinidad
Issue Type: Task
Components: Skinning
Affects Versions: 1.2.10-core, 1.0.10-core
Reporter: Simon Lessard
Priority: Minor
Trinidad's skinning engine has been around for very long (UIX). Over the time, as features were added, the code, as it's often the case, got a little bit bloated and hard to understand. Some cleanup could definitely help on that. The main issue is the interdependency between StyleContext and StyleProvider, but it's not the only one. There's also the way selector limit is handled that I currently added. While it work, as mentioned in the JIRA ticket https://issues.apache.org/jira/browse/TRINIDAD-205 for some comment references, some form of interface would be much cleaner to make most methods Agent agnostic. One way I thought of would be to add something like a getStyleSheetWriter to StyleProvider that would return a writer able to create files as needed when the current agent suffers from a selector limitation (only IE to my knowledge)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.