You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/19 00:19:45 UTC

[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #8595: [dashboard scoped filter] Reduce calls to expensive safeStringify

graceguo-supercat opened a new pull request #8595: [dashboard scoped filter] Reduce calls to expensive safeStringify
URL: https://github.com/apache/incubator-superset/pull/8595
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   In dashboard scoped filter feature #8590, I introduced a few calls to  `safeStringify`. It cause slower render for large dashboard. So I run profiling, i can see the root causes:
   ![Screen Shot 2019-11-18 at 4 16 46 PM](https://user-images.githubusercontent.com/27990562/69104983-e7a70200-0a1e-11ea-990d-0ab969121bcd.png)
   
   This PR is remove a few newly introduced `safeStringify`.
   
   
   After this fix:
   ![Screen Shot 2019-11-18 at 4 05 44 PM](https://user-images.githubusercontent.com/27990562/69105079-1f15ae80-0a1f-11ea-809d-4a71e3511546.png)
   
   
   ### TEST PLAN
   manual test
   
   
   ### REVIEWERS
   @etr2460 @kristw 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org