You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modperl-cvs@perl.apache.org by st...@apache.org on 2004/04/29 02:06:41 UTC
cvs commit: modperl-2.0/xs/Apache/RequestIO Apache__RequestIO.h
stas 2004/04/28 17:06:41
Modified: xs/Apache/RequestIO Apache__RequestIO.h
Log:
eliminate one more place where $! was being set to a string, which is
wrong
Revision Changes Path
1.45 +1 -4 modperl-2.0/xs/Apache/RequestIO/Apache__RequestIO.h
Index: Apache__RequestIO.h
===================================================================
RCS file: /home/cvs/modperl-2.0/xs/Apache/RequestIO/Apache__RequestIO.h,v
retrieving revision 1.44
retrieving revision 1.45
diff -u -u -r1.44 -r1.45
--- Apache__RequestIO.h 14 Apr 2004 03:41:39 -0000 1.44
+++ Apache__RequestIO.h 29 Apr 2004 00:06:41 -0000 1.45
@@ -233,10 +233,7 @@
}
if (len <= 0) {
- sv_setpv(get_sv("!", TRUE),
- (char *)apr_psprintf(r->pool,
- "The LENGTH argument can't be negative"));
- return &PL_sv_undef;
+ Perl_croak(aTHX_ "The LENGTH argument can't be negative");
}
/* XXX: need to handle negative offset */