You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/08/16 14:33:17 UTC
[GitHub] [ozone] mukul1987 commented on a change in pull request #2538: HDDS-5619. Ozone data corruption issue on follower node.
mukul1987 commented on a change in pull request #2538:
URL: https://github.com/apache/ozone/pull/2538#discussion_r689589409
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java
##########
@@ -678,6 +694,19 @@ private ByteString readStateMachineData(
}
}
+ private void getReadStateMachineFuture(
+ CompletableFuture<ByteString> readStateMachineFuture,
+ ContainerCommandRequestProto requestProto, LogEntryProto entry) {
+ try {
+ readStateMachineFuture.complete(
+ readStateMachineData(requestProto, entry.getTerm(),
+ entry.getIndex()));
+ } catch (IOException e) {
+ metrics.incNumReadStateMachineFails();
+ readStateMachineFuture.completeExceptionally(e);
Review comment:
we should mark the statemachine unhealthy and container unhealthy if we fail here ?
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/freon/TestRandomKeyGenerator.java
##########
@@ -36,7 +36,7 @@
/**
* Tests Freon, with MiniOzoneCluster.
*/
-@Ignore("HDDS-3290")
+//@Ignore("HDDS-3290")
Review comment:
Lets remove the @Ignore here
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java
##########
@@ -52,6 +52,8 @@
public static final String DISK_CHECK_TIMEOUT_KEY =
"hdds.datanode.disk.check.timeout";
+ static final boolean CHUNK_DATA_VALIDATION_CHECK_DEFAULT = true;
Review comment:
The value is set to true by default, lets have this as false by default but lets enable this in MiniOzoneCluster
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/freon/TestRandomKeyGenerator.java
##########
@@ -62,6 +62,7 @@ public static void init() throws Exception {
raftClientConfig.setRpcRequestTimeout(Duration.ofSeconds(3));
raftClientConfig.setRpcWatchRequestTimeout(Duration.ofSeconds(3));
conf.setFromObject(raftClientConfig);
+ conf.setBoolean("hdds.datanode.chunk.data.validation.check", true);
Review comment:
I will suggest that lets enable this flag by default on all the unit test via MiniOzoneCluster and also docker based tests.
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/freon/TestRandomKeyGenerator.java
##########
@@ -127,7 +128,7 @@ public void ratisTest3() throws Exception {
}
@Test
- @Ignore("HDDS-2011")
+ //@Ignore("HDDS-2011")
Review comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org