You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2018/09/22 13:37:22 UTC
[Bug 7634] New: GeoDB module for unified geodatabase handling
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7634
Bug ID: 7634
Summary: GeoDB module for unified geodatabase handling
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P2
Component: Libraries
Assignee: dev@spamassassin.apache.org
Reporter: hege@hege.li
Target Milestone: Undefined
Introducing Mail::SpamAssassin::GeoDB module, which RelayCountry and URILocalBL
now use.
Currently supporting these geomodules:
GeoIP2::Database::Reader
Geo::IP
IP::Country::DB_File (untested, imho useless anyway)
IP::Country::Fast
Geo::IP/GeoIP2 intelligently searches directories for existing databases.
URILocalBL also received a large code overhaul while integrating this.
I created small test databases in t/data/geodb for GeoIP and GeoIP2, which only
contain 8.8.8.8. So "make test" will work even without any existing databases.
New settings:
geodb_module
geodb_options
geodb_search_path
Deprecated settings, still work but warns user:
country_db_type
country_db_path
uri_country_db_path
uri_country_db_isp_path
Please test if you can.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7634] GeoDB module for unified geodatabase handling
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7634
Henrik Krohns <he...@hege.li> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #13 from Henrik Krohns <he...@hege.li> ---
Sending UPGRADE
Transmitting file data .done
Committing transaction...
Committed revision 1841824.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7634] GeoDB module for unified geodatabase handling
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7634
--- Comment #6 from Henrik Krohns <he...@hege.li> ---
(In reply to Giovanni Bechis from comment #5)
> (In reply to Henrik Krohns from comment #0)
> > Introducing Mail::SpamAssassin::GeoDB module, which RelayCountry and
> > URILocalBL now use.
> >
> > Currently supporting these geomodules:
> >
> > GeoIP2::Database::Reader
> > Geo::IP
> > IP::Country::DB_File (untested, imho useless anyway)
> > IP::Country::Fast
> >
> I am using IP::Country::DB_File where GeoIP2 is
> not available and I cannot install all
> its dependecies from cpan.
> IP::Country::Fast is not an option an all machines,
> creating its database needs a lot of ram,
> creating IP::Country::DB_File database instead is
> definitely faster.
I'm hosting IP::Country::Fast databases, mentioned in wiki also:
http://mailfud.org/ip-country-fast/
(It's pretty silly one has to update them deep in Perl module directories..)
Perhaps I'll look into DB_File too.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7634] GeoDB module for unified geodatabase handling
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7634
--- Comment #10 from Kevin A. McGrail <km...@apache.org> ---
(In reply to Henrik Krohns from comment #9)
> Should this be applied to 3.4 along with all the RelayCountry/URILocalBL
> changes? I'm not sure what the roadmap for everything is.
*My* opinion on the roadmap is to try and start the release of 3.4.3 on or by
Oct 15. It can take a few weeks to jump all the hurdles.
Then work on 4.0 to release on schedule on Jan 30.
Your thoughts on the dev list would be good. -KAM
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7634] GeoDB module for unified geodatabase handling
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7634
Henrik Krohns <he...@hege.li> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hege@hege.li
--- Comment #1 from Henrik Krohns <he...@hege.li> ---
Sending MANIFEST
Sending lib/Mail/SpamAssassin/Conf.pm
Adding lib/Mail/SpamAssassin/GeoDB.pm
Sending lib/Mail/SpamAssassin/Plugin/RelayCountry.pm
Sending lib/Mail/SpamAssassin/Plugin/URILocalBL.pm
Adding t/data/geodb
Adding (bin) t/data/geodb/GeoIP2-City.mmdb
Adding (bin) t/data/geodb/GeoIP2-Country.mmdb
Adding (bin) t/data/geodb/GeoIP2-ISP.mmdb
Adding (bin) t/data/geodb/GeoIPCity.dat
Adding (bin) t/data/geodb/GeoIPISP.dat
Adding t/data/geodb/create_GeoIP2-City.pl
Adding t/data/geodb/create_GeoIP2-Country.pl
Adding t/data/geodb/create_GeoIP2-ISP.pl
Adding t/data/geodb/create_GeoIPCity.README
Adding t/data/geodb/create_GeoIPISP.README
Sending t/data/spam/relayUS.eml
Sending t/relaycountry_fast.t
Sending t/relaycountry_geoip.t
Sending t/relaycountry_geoip2.t
Adding t/urilocalbl_fast.t
Sending t/urilocalbl_geoip.t
Adding t/urilocalbl_geoip2.t
Transmitting file data ......................done
Committing transaction...
Committed revision 1841681.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7634] GeoDB module for unified geodatabase handling
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7634
--- Comment #7 from Giovanni Bechis <gi...@paclan.it> ---
(In reply to Giovanni Bechis from comment #5)
> (In reply to Henrik Krohns from comment #0)
> > Introducing Mail::SpamAssassin::GeoDB module, which RelayCountry and
> > URILocalBL now use.
> >
> > Currently supporting these geomodules:
> >
> > GeoIP2::Database::Reader
> > Geo::IP
> > IP::Country::DB_File (untested, imho useless anyway)
> > IP::Country::Fast
> >
> I am using IP::Country::DB_File where GeoIP2 is
> not available and I cannot install all
> its dependecies from cpan.
> IP::Country::Fast is not an option an all machines,
> creating its database needs a lot of ram,
> creating IP::Country::DB_File database instead is
> definitely faster.
As a plus IP::Country::DB_File is ipv6-ready as well.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7634] GeoDB module for unified geodatabase handling
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7634
John Hardin <jh...@impsec.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jhardin@impsec.org
--- Comment #12 from John Hardin <jh...@impsec.org> ---
(In reply to Bill Cole from comment #11)
> (In reply to Henrik Krohns from comment #9)
> > Should this be applied to 3.4 along with all the RelayCountry/URILocalBL
> > changes? I'm not sure what the roadmap for everything is.
>
> I'd vote no. My understanding of 3.4.3 is aligned with Kevin's: it should be
> a pure bug-fix release. Architectural novelty should be left for 4.x.
Agreed. +1 from me on 3.4.3 being bugfix-only for 3.4 branch finalization.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7634] GeoDB module for unified geodatabase handling
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7634
Kevin A. McGrail <km...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail@apache.org
--- Comment #2 from Kevin A. McGrail <km...@apache.org> ---
you should create a pre file for 4.0 and add these commented like we did for
v3.4.2
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7634] GeoDB module for unified geodatabase handling
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7634
--- Comment #9 from Henrik Krohns <he...@hege.li> ---
Should this be applied to 3.4 along with all the RelayCountry/URILocalBL
changes? I'm not sure what the roadmap for everything is.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7634] GeoDB module for unified geodatabase handling
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7634
--- Comment #3 from Henrik Krohns <he...@hege.li> ---
There's nothing to add. RelayCountry and URILocalBL exist already in pre files.
GeoDB is internal support module, not a Plugin.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7634] GeoDB module for unified geodatabase handling
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7634
--- Comment #4 from Kevin A. McGrail <km...@apache.org> ---
Brilliant :-)
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7634] GeoDB module for unified geodatabase handling
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7634
Giovanni Bechis <gi...@paclan.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |giovanni@paclan.it
--- Comment #5 from Giovanni Bechis <gi...@paclan.it> ---
(In reply to Henrik Krohns from comment #0)
> Introducing Mail::SpamAssassin::GeoDB module, which RelayCountry and
> URILocalBL now use.
>
> Currently supporting these geomodules:
>
> GeoIP2::Database::Reader
> Geo::IP
> IP::Country::DB_File (untested, imho useless anyway)
> IP::Country::Fast
>
I am using IP::Country::DB_File where GeoIP2 is
not available and I cannot install all
its dependecies from cpan.
IP::Country::Fast is not an option an all machines,
creating its database needs a lot of ram,
creating IP::Country::DB_File database instead is
definitely faster.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7634] GeoDB module for unified geodatabase handling
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7634
Bill Cole <bi...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |billcole@apache.org
--- Comment #11 from Bill Cole <bi...@apache.org> ---
(In reply to Henrik Krohns from comment #9)
> Should this be applied to 3.4 along with all the RelayCountry/URILocalBL
> changes? I'm not sure what the roadmap for everything is.
I'd vote no. My understanding of 3.4.3 is aligned with Kevin's: it should be a
pure bug-fix release. Architectural novelty should be left for 4.x.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7634] GeoDB module for unified geodatabase handling
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7634
--- Comment #8 from Henrik Krohns <he...@hege.li> ---
Well DB_File does look ok and is easy to create. Fixed support and testfiles
too.
Committed revision 1841697.
Also made update page for it. :-) http://mailfud.org/ip-country-dbfile/
--
You are receiving this mail because:
You are the assignee for the bug.