You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/07 15:25:10 UTC
[GitHub] [hadoop-ozone] elek opened a new pull request #781: fix server-side
dependencies
elek opened a new pull request #781: fix server-side dependencies
URL: https://github.com/apache/hadoop-ozone/pull/781
## What changes were proposed in this pull request?
Similar to HDDS-3312 we can exclude dependencies coming from hadoop-ozone. (Eg. curator / zookeeper.)
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3353
## How was this patch tested?
CI: https://github.com/elek/hadoop-ozone/actions/runs/72677849
+ `find -name "*curator*.jar"`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] fapifta commented on issue #781: HDDS-3353. Remove
unnecessary transitive hadoop-common dependencies on server side.
Posted by GitBox <gi...@apache.org>.
fapifta commented on issue #781: HDDS-3353. Remove unnecessary transitive hadoop-common dependencies on server side.
URL: https://github.com/apache/hadoop-ozone/pull/781#issuecomment-610946563
Right, thank you guys, I will create the JIRA and the PR later today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek closed pull request #781: HDDS-3353. Remove
unnecessary transitive hadoop-common dependencies on server side.
Posted by GitBox <gi...@apache.org>.
elek closed pull request #781: HDDS-3353. Remove unnecessary transitive hadoop-common dependencies on server side.
URL: https://github.com/apache/hadoop-ozone/pull/781
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] fapifta commented on issue #781: HDDS-3353. Remove
unnecessary transitive hadoop-common dependencies on server side.
Posted by GitBox <gi...@apache.org>.
fapifta commented on issue #781: HDDS-3353. Remove unnecessary transitive hadoop-common dependencies on server side.
URL: https://github.com/apache/hadoop-ozone/pull/781#issuecomment-610495296
Hi Marton, thank you for taking this on and looking into my suggestion deeper.
I ran a search for the string curator in the code, and found one more thing. I have added a pull request against your fork with the fix, please review and commit it if you agree.
The change to have a centralized dependency for the server and for the tests is a way I really like, and I am +1 on that part of the implementation.
I have done a quick check where we use hadoop-common as a dependency, and how we manage it there, and the followings came up:
- mini-chaos-tests, insight, integration-tests, tools, common, container-service, client: are list hadoop-common as a dependency, we may use the new tests dependency here
- hadoop-ozone-fs, csi: pom mentions hadoop-common but as an exclusion this is fine
This is on its way as a PR to your branch also, after a quick local build.
On the other hand, I am unsure whether after these changes we need the hadoop-common dependency to be listed in the DependencyManagement section of the main pom.xml, as we use the hadoop.version property in the 3 remaining place in hadoop-dependency-server, in hadoop-dependency-test, and in hadoop-dependency-client and all modules now depends on these pseudo modules. My guess is we need it, but I am not that deeply familiar with dependency resolution to understand this easily so I thought to ask first. ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on issue #781: HDDS-3353. Remove
unnecessary transitive hadoop-common dependencies on server side.
Posted by GitBox <gi...@apache.org>.
elek commented on issue #781: HDDS-3353. Remove unnecessary transitive hadoop-common dependencies on server side.
URL: https://github.com/apache/hadoop-ozone/pull/781#issuecomment-610848775
> I would like to suggest merging this as it is, and ask @fapifta open a PR against apache/hadoop-ozone to get credit for the addendum.
Good idea, especially because @fapifta's proposals are also very good.
Thanks to review to both of you. I am merging it and let's make an official PR/jira from the addendum for further improvements...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org