You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "justinwwhuang (via GitHub)" <gi...@apache.org> on 2024/05/27 12:11:47 UTC
[PR] [INLONG-10281][Agent] Real time file collection takes the current time as the data time [inlong]
justinwwhuang opened a new pull request, #10282:
URL: https://github.com/apache/inlong/pull/10282
Fixes #10281
### Motivation
Real time file collection need to take the current time as the data time
### Modifications
Real time file collection uses the current time as the audit time and data, and transmits it downstream
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
No doc needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10281][Agent] Real time file collection takes the current time as the data time [inlong]
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang commented on code in PR #10282:
URL: https://github.com/apache/inlong/pull/10282#discussion_r1616506121
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/message/file/ProxyMessageCache.java:
##########
@@ -81,6 +82,10 @@ public ProxyMessageCache(InstanceProfile instanceProfile, String groupId, String
extraMap.put(AttributeConstants.MESSAGE_SYNC_SEND, "false");
extraMap.putAll(AgentUtils.parseAddAttrToMap(instanceProfile.getPredefineFields()));
extraMap.put(AUDIT_VERSION, instanceProfile.get(TASK_AUDIT_VERSION));
+ String cycleUnit = instanceProfile.get(TASK_CYCLE_UNIT);
+ if (cycleUnit.compareToIgnoreCase(CycleUnitType.REAL_TIME) == 0) {
Review Comment:
```suggestion
if (cycleUnit.equalsIgnoreCase(CycleUnitType.REAL_TIME)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10281][Agent] Real time file collection takes the current time as the data time [inlong]
Posted by "justinwwhuang (via GitHub)" <gi...@apache.org>.
justinwwhuang merged PR #10282:
URL: https://github.com/apache/inlong/pull/10282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org