[GitHub] ashb commented on a change in pull request #4533: [WIP][AIRFLOW-3702] Reverse Backfilling

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #4533: [WIP][AIRFLOW-3702] Reverse Backfilling
URL: https://github.com/apache/airflow/pull/4533#discussion_r248063013
 
 

 ##########
 File path: airflow/jobs.py
 ##########
 @@ -2391,6 +2391,13 @@ def _execute_for_run_dates(self, run_dates, ti_status, executor, pickle_id,
         :param session: the current session object
         :type session: Session
         """
+        backfill_dagrun_order_reverse = conf.getboolean('scheduler',
+                                                        'backfill_dagrun_order_reverse')
+        ignore_depends_on_past = self.ignore_first_depends_on_past
+        is_reversed = backfill_dagrun_order_reverse and ignore_depends_on_past
+        if is_reversed:
+            # create dag run in reversed
+            run_dates = run_dates[::-1]
 
 Review comment:
   Is there some flag on the dag that we look at to examine if the DAG does depend on past or not? Cos if not then not having to specify `-I` would be nice.
   
   Seeing this behaviour/need I now think that this shouldn't be a config option.
   
   Additionally if `-I` isn't passed then this config setting is silently ignored - that is going to be confusing, and this case should be an error.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services