You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Tim Armstrong (Jira)" <ji...@apache.org> on 2020/08/13 20:56:00 UTC
[jira] [Updated] (IMPALA-6138) Thread creation failure in
TAcceptQueueServer may cause crash
[ https://issues.apache.org/jira/browse/IMPALA-6138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Armstrong updated IMPALA-6138:
----------------------------------
Labels: (was: crash)
> Thread creation failure in TAcceptQueueServer may cause crash
> -------------------------------------------------------------
>
> Key: IMPALA-6138
> URL: https://issues.apache.org/jira/browse/IMPALA-6138
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 2.10.0
> Reporter: Sailesh Mukil
> Priority: Major
>
> We recently added a patch to catch all exceptions thrown by boost while creating threads:
> https://github.com/apache/incubator-impala/commit/e993b9712c81dfb66fdf65bb5269cdc38a8eef18#diff-66eda90b98c0bdfb1cd6e6c0a97e97fa
> However, in one case, we still do not catch the exceptions. We pass in a Thread factory into thrift so that it uses Impala code to create threads:
> https://github.com/apache/incubator-impala/blob/master/be/src/rpc/thrift-thread.cc#L57
> And that throws an exception on an inability to create threads:
> https://github.com/apache/incubator-impala/blob/master/be/src/rpc/thrift-thread.cc#L41
> The possible point of failure in TAcceptQueueServer is:
> https://github.com/apache/incubator-impala/blob/master/be/src/rpc/TAcceptQueueServer.cpp#L163
> Nothing catches this exception, which means that if TAcceptQueueServer is unable to create a thread, the process will crash.
> One way to handle this would be to have the users of TAcceptQueueServer handle exceptions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org