You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/12 16:21:55 UTC

[GitHub] [pulsar] lhotari commented on a change in pull request #10196: [Broker] Close namespace clients when PulsarService is closed

lhotari commented on a change in pull request #10196:
URL: https://github.com/apache/pulsar/pull/10196#discussion_r611774850



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java
##########
@@ -1388,4 +1391,15 @@ public void registerOwnedBundles() {
             }
         });
     }
+
+    @Override
+    public void close() throws IOException {

Review comment:
       @eolivelli  good point. I'll switch to use `AutoCloseable`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org