You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/27 18:01:58 UTC

[GitHub] [incubator-nuttx-apps] rurtle commented on a change in pull request #443: Changes for nuttx issue 1883

rurtle commented on a change in pull request #443:
URL: https://github.com/apache/incubator-nuttx-apps/pull/443#discussion_r512913985



##########
File path: nshlib/nsh_netcmds.c
##########
@@ -391,7 +391,9 @@ static int nsh_foreach_netdev(nsh_netdev_callback_t callback,
   dir = opendir(CONFIG_NSH_PROC_MOUNTPOINT "/net");

Review comment:
       @xiaoxiang781216 Mistakenly I requested a review. Sorry about that.
   
   I agree with your comment though. Looks like the changes will spread across a few more files in that case. I shall make necessary changes tomorrow morning and send it back for review. Thank you.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org