[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #10498: feat: welcome presto to the suite of tested databases

[GitBox <gi...@apache.org>]

bkyryliuk commented on a change in pull request #10498:
URL: https://github.com/apache/incubator-superset/pull/10498#discussion_r465400301



##########
File path: superset/utils/core.py
##########
@@ -1022,6 +1022,13 @@ def get_example_database() -> "Database":
     return get_or_create_db("examples", db_uri)
 
 
+def get_main_database() -> "Database":

Review comment:
       it is called in superset as a main database on the dev installation, I am fine with renaming it - however we should probably do it across the board in a separate PR




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org