You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/03/17 22:45:17 UTC

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6693: make resizeTimeMs metric as a Gauge instead of a Meter

siddharthteotia commented on a change in pull request #6693:
URL: https://github.com/apache/incubator-pinot/pull/6693#discussion_r596433057



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java
##########
@@ -41,6 +41,7 @@
   REALTIME_OFFHEAP_MEMORY_USED("bytes", false),
   REALTIME_SEGMENT_NUM_PARTITIONS("realtimeSegmentNumPartitions", false),
   LLC_SIMULTANEOUS_SEGMENT_BUILDS("llcSimultaneousSegmentBuilds", true),
+  RESIZE_TIME_MS("resizeTimeMs", false),

Review comment:
       This should be defined as RESIZE_TIME_MS("milliSeconds", false). See the other duration related gauge metrics. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org