You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/25 02:48:08 UTC
[GitHub] [kafka] huxihx opened a new pull request #9218: MINOR: Fix shouldNotResetEpochHistoryHeadIfUndefinedPassed
huxihx opened a new pull request #9218:
URL: https://github.com/apache/kafka/pull/9218
In LeaderEpochFileCacheTest.scala, code is identical for `shouldNotResetEpochHistoryHeadIfUndefinedPassed` and `shouldNotResetEpochHistoryTailIfUndefinedPassed`. Seems `truncateFromStart` should be invoked in `shouldNotResetEpochHistoryHeadIfUndefinedPassed` instead of `truncateFromEnd`.
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] huxihx commented on pull request #9218: MINOR: Fix shouldNotResetEpochHistoryHeadIfUndefinedPassed
Posted by GitBox <gi...@apache.org>.
huxihx commented on pull request #9218:
URL: https://github.com/apache/kafka/pull/9218#issuecomment-697095836
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] huxihx commented on pull request #9218: MINOR: Fix shouldNotResetEpochHistoryHeadIfUndefinedPassed
Posted by GitBox <gi...@apache.org>.
huxihx commented on pull request #9218:
URL: https://github.com/apache/kafka/pull/9218#issuecomment-707439275
@ijuma Thanks for the review, merging to trunk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] huxihx commented on pull request #9218: MINOR: Fix shouldNotResetEpochHistoryHeadIfUndefinedPassed
Posted by GitBox <gi...@apache.org>.
huxihx commented on pull request #9218:
URL: https://github.com/apache/kafka/pull/9218#issuecomment-694743368
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #9218: MINOR: Fix shouldNotResetEpochHistoryHeadIfUndefinedPassed
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9218:
URL: https://github.com/apache/kafka/pull/9218#issuecomment-694648140
Can you please rebase so that we get the new CI running?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] huxihx merged pull request #9218: MINOR: Fix shouldNotResetEpochHistoryHeadIfUndefinedPassed
Posted by GitBox <gi...@apache.org>.
huxihx merged pull request #9218:
URL: https://github.com/apache/kafka/pull/9218
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] huxihx commented on pull request #9218: MINOR: Fix shouldNotResetEpochHistoryHeadIfUndefinedPassed
Posted by GitBox <gi...@apache.org>.
huxihx commented on pull request #9218:
URL: https://github.com/apache/kafka/pull/9218#issuecomment-697095836
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] huxihx commented on pull request #9218: MINOR: Fix shouldNotResetEpochHistoryHeadIfUndefinedPassed
Posted by GitBox <gi...@apache.org>.
huxihx commented on pull request #9218:
URL: https://github.com/apache/kafka/pull/9218#issuecomment-706985770
@ijuma Please take some time to review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] huxihx commented on pull request #9218: MINOR: Fix shouldNotResetEpochHistoryHeadIfUndefinedPassed
Posted by GitBox <gi...@apache.org>.
huxihx commented on pull request #9218:
URL: https://github.com/apache/kafka/pull/9218#issuecomment-681198703
@ijuma Please review this patch. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org