You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Stanton Sievers (Created) (JIRA)" <ji...@apache.org> on 2011/10/10 22:20:32 UTC
[jira] [Created] (SHINDIG-1637) Introduce abstract
LockedDomainService implementation to enable easier customization
Introduce abstract LockedDomainService implementation to enable easier customization
------------------------------------------------------------------------------------
Key: SHINDIG-1637
URL: https://issues.apache.org/jira/browse/SHINDIG-1637
Project: Shindig
Issue Type: Improvement
Components: Java
Affects Versions: 3.0.0
Reporter: Stanton Sievers
Priority: Minor
Fix For: 3.0.0
Currently when one wants to created a customized LockedDomainService, one has to implement all of the functionality from scratch. The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (SHINDIG-1637) Introduce abstract
LockedDomainService implementation to enable easier customization
Posted by "Paul Lindner (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner closed SHINDIG-1637.
---------------------------------
part of 2.5.0-beta1 release.
> Introduce abstract LockedDomainService implementation to enable easier customization
> ------------------------------------------------------------------------------------
>
> Key: SHINDIG-1637
> URL: https://issues.apache.org/jira/browse/SHINDIG-1637
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.5.0-beta1
> Reporter: Stanton Sievers
> Priority: Minor
> Fix For: 2.5.0-beta1
>
> Attachments: LockedDomainServiceImplPatchv3.txt
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Currently when one wants to created a customized LockedDomainService, one has to implement all of the functionality from scratch. The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1637) Introduce abstract
LockedDomainService implementation to enable easier customization
Posted by "Paul Lindner (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126058#comment-13126058 ]
Paul Lindner commented on SHINDIG-1637:
---------------------------------------
fyi - click on 'subversion commits' tab to see matching commits (based on SHINDIG-XXX in the commit log message)
> Introduce abstract LockedDomainService implementation to enable easier customization
> ------------------------------------------------------------------------------------
>
> Key: SHINDIG-1637
> URL: https://issues.apache.org/jira/browse/SHINDIG-1637
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 3.0.0
> Reporter: Stanton Sievers
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: LockedDomainServiceImplPatchv3.txt
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Currently when one wants to created a customized LockedDomainService, one has to implement all of the functionality from scratch. The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1637) Introduce abstract
LockedDomainService implementation to enable easier customization
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125445#comment-13125445 ]
jiraposter@reviews.apache.org commented on SHINDIG-1637:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2333/
-----------------------------------------------------------
(Updated 2011-10-11 22:27:26.456238)
Review request for Ryan Baxter and Dan Dumont.
Changes
-------
New patch based on Dan's review. Also removed some extraneous @Overrides I found while making changes in RendererTest that would break the Java 5 build.
Summary
-------
The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
Sorry for the horrible diffs. I moved a lot of stuff around in HashLockedDomainService.
This addresses bug SHINDIG-1637.
https://issues.apache.org/jira/browse/SHINDIG-1637
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractLockedDomainService.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java 1181021
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainService.java 1181021
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/HashLockedDomainServiceTest.java 1181021
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RendererTest.java 1181021
Diff: https://reviews.apache.org/r/2333/diff
Testing
-------
Updated and ran existing JUnits.
Thanks,
Stanton
> Introduce abstract LockedDomainService implementation to enable easier customization
> ------------------------------------------------------------------------------------
>
> Key: SHINDIG-1637
> URL: https://issues.apache.org/jira/browse/SHINDIG-1637
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 3.0.0
> Reporter: Stanton Sievers
> Priority: Minor
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Currently when one wants to created a customized LockedDomainService, one has to implement all of the functionality from scratch. The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1637) Introduce abstract
LockedDomainService implementation to enable easier customization
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125335#comment-13125335 ]
jiraposter@reviews.apache.org commented on SHINDIG-1637:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2333/#review2517
-----------------------------------------------------------
FYI:
In eclipse, Ctrl+F
Find: [ \t]+$
Replace with:
Check off "Regular expressions" and then press "Replace All" :)
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java
<https://reviews.apache.org/r/2333/#comment5681>
White space, and 2 below
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java
<https://reviews.apache.org/r/2333/#comment5682>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java
<https://reviews.apache.org/r/2333/#comment5683>
As we talked about offline, could you remove this method from the interface and abstract implementation? And make this method in this class private? It seems to be a private impl detail that doesn't need to be exposed.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5685>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5684>
Would this be an Impl if it's an abstract class? It's more of a partial impl...
Is there already a practice in Shindig to postfix abstract classes with "Impl" if they attempt to implement parts of an interface? (just curious)
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5686>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5687>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5688>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5689>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5690>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5691>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5692>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5693>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5694>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5695>
White space
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java
<https://reviews.apache.org/r/2333/#comment5696>
White space
- Dan
On 2011-10-10 20:23:15, Stanton Sievers wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2333/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-10 20:23:15)
bq.
bq.
bq. Review request for Ryan Baxter and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
bq.
bq. Sorry for the horrible diffs. I moved a lot of stuff around in HashLockedDomainService.
bq.
bq.
bq. This addresses bug SHINDIG-1637.
bq. https://issues.apache.org/jira/browse/SHINDIG-1637
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java 1181021
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/HashLockedDomainServiceTest.java 1181021
bq.
bq. Diff: https://reviews.apache.org/r/2333/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated and ran existing JUnits.
bq.
bq.
bq. Thanks,
bq.
bq. Stanton
bq.
bq.
> Introduce abstract LockedDomainService implementation to enable easier customization
> ------------------------------------------------------------------------------------
>
> Key: SHINDIG-1637
> URL: https://issues.apache.org/jira/browse/SHINDIG-1637
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 3.0.0
> Reporter: Stanton Sievers
> Priority: Minor
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Currently when one wants to created a customized LockedDomainService, one has to implement all of the functionality from scratch. The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1637) Introduce abstract
LockedDomainService implementation to enable easier customization
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125771#comment-13125771 ]
jiraposter@reviews.apache.org commented on SHINDIG-1637:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2333/#review2530
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractLockedDomainService.java
<https://reviews.apache.org/r/2333/#comment5704>
This probably isn't very expensive to pull stuff from the config since it is already in memory but instead of calling config.getBool in the loop every time you could assign it to a local variable above and just call it once
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractLockedDomainService.java
<https://reviews.apache.org/r/2333/#comment5705>
Fill out javadoc
- Ryan
On 2011-10-11 22:27:26, Stanton Sievers wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2333/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-11 22:27:26)
bq.
bq.
bq. Review request for Ryan Baxter and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
bq.
bq. Sorry for the horrible diffs. I moved a lot of stuff around in HashLockedDomainService.
bq.
bq.
bq. This addresses bug SHINDIG-1637.
bq. https://issues.apache.org/jira/browse/SHINDIG-1637
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractLockedDomainService.java PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java 1181021
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainService.java 1181021
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/HashLockedDomainServiceTest.java 1181021
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RendererTest.java 1181021
bq.
bq. Diff: https://reviews.apache.org/r/2333/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated and ran existing JUnits.
bq.
bq.
bq. Thanks,
bq.
bq. Stanton
bq.
bq.
> Introduce abstract LockedDomainService implementation to enable easier customization
> ------------------------------------------------------------------------------------
>
> Key: SHINDIG-1637
> URL: https://issues.apache.org/jira/browse/SHINDIG-1637
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 3.0.0
> Reporter: Stanton Sievers
> Priority: Minor
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Currently when one wants to created a customized LockedDomainService, one has to implement all of the functionality from scratch. The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1637) Introduce abstract
LockedDomainService implementation to enable easier customization
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124456#comment-13124456 ]
jiraposter@reviews.apache.org commented on SHINDIG-1637:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2333/
-----------------------------------------------------------
(Updated 2011-10-10 20:20:25.067650)
Review request for Dan Dumont.
Changes
-------
Creating JIRA
Summary
-------
The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
Sorry for the horrible diffs. I moved a lot of stuff around in HashLockedDomainService.
This addresses bug SHINDIG-1637.
https://issues.apache.org/jira/browse/SHINDIG-1637
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java 1181021
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/HashLockedDomainServiceTest.java 1181021
Diff: https://reviews.apache.org/r/2333/diff
Testing
-------
Updated and ran existing JUnits.
Thanks,
Stanton
> Introduce abstract LockedDomainService implementation to enable easier customization
> ------------------------------------------------------------------------------------
>
> Key: SHINDIG-1637
> URL: https://issues.apache.org/jira/browse/SHINDIG-1637
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 3.0.0
> Reporter: Stanton Sievers
> Priority: Minor
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Currently when one wants to created a customized LockedDomainService, one has to implement all of the functionality from scratch. The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1637) Introduce abstract
LockedDomainService implementation to enable easier customization
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125864#comment-13125864 ]
jiraposter@reviews.apache.org commented on SHINDIG-1637:
--------------------------------------------------------
bq. On 2011-10-12 12:19:00, Ryan Baxter wrote:
bq. > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractLockedDomainService.java, line 55
bq. > <https://reviews.apache.org/r/2333/diff/2/?file=49558#file49558line55>
bq. >
bq. > This probably isn't very expensive to pull stuff from the config since it is already in memory but instead of calling config.getBool in the loop every time you could assign it to a local variable above and just call it once
config.getBool takes the container and that's what we're looping over, so it can't be pulled out.
- Stanton
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2333/#review2530
-----------------------------------------------------------
On 2011-10-12 14:00:29, Stanton Sievers wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2333/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-12 14:00:29)
bq.
bq.
bq. Review request for Ryan Baxter and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
bq.
bq. Sorry for the horrible diffs. I moved a lot of stuff around in HashLockedDomainService.
bq.
bq.
bq. This addresses bug SHINDIG-1637.
bq. https://issues.apache.org/jira/browse/SHINDIG-1637
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractLockedDomainService.java PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java 1181021
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainService.java 1181021
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/HashLockedDomainServiceTest.java 1181021
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RendererTest.java 1181021
bq.
bq. Diff: https://reviews.apache.org/r/2333/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated and ran existing JUnits.
bq.
bq.
bq. Thanks,
bq.
bq. Stanton
bq.
bq.
> Introduce abstract LockedDomainService implementation to enable easier customization
> ------------------------------------------------------------------------------------
>
> Key: SHINDIG-1637
> URL: https://issues.apache.org/jira/browse/SHINDIG-1637
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 3.0.0
> Reporter: Stanton Sievers
> Priority: Minor
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Currently when one wants to created a customized LockedDomainService, one has to implement all of the functionality from scratch. The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1637) Introduce abstract
LockedDomainService implementation to enable easier customization
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125950#comment-13125950 ]
jiraposter@reviews.apache.org commented on SHINDIG-1637:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2333/
-----------------------------------------------------------
(Updated 2011-10-12 16:11:47.242307)
Review request for shindig, Ryan Baxter and Dan Dumont.
Changes
-------
Adding the larger dev list audience
Summary
-------
The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
Sorry for the horrible diffs. I moved a lot of stuff around in HashLockedDomainService.
This addresses bug SHINDIG-1637.
https://issues.apache.org/jira/browse/SHINDIG-1637
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractLockedDomainService.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java 1181021
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainService.java 1181021
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/HashLockedDomainServiceTest.java 1181021
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RendererTest.java 1181021
Diff: https://reviews.apache.org/r/2333/diff
Testing
-------
Updated and ran existing JUnits.
Thanks,
Stanton
> Introduce abstract LockedDomainService implementation to enable easier customization
> ------------------------------------------------------------------------------------
>
> Key: SHINDIG-1637
> URL: https://issues.apache.org/jira/browse/SHINDIG-1637
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 3.0.0
> Reporter: Stanton Sievers
> Priority: Minor
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Currently when one wants to created a customized LockedDomainService, one has to implement all of the functionality from scratch. The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1637) Introduce abstract
LockedDomainService implementation to enable easier customization
Posted by "Paul Lindner (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-1637.
-----------------------------------
Resolution: Fixed
> Introduce abstract LockedDomainService implementation to enable easier customization
> ------------------------------------------------------------------------------------
>
> Key: SHINDIG-1637
> URL: https://issues.apache.org/jira/browse/SHINDIG-1637
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 3.0.0
> Reporter: Stanton Sievers
> Priority: Minor
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Currently when one wants to created a customized LockedDomainService, one has to implement all of the functionality from scratch. The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1637) Introduce abstract
LockedDomainService implementation to enable easier customization
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125865#comment-13125865 ]
jiraposter@reviews.apache.org commented on SHINDIG-1637:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2333/
-----------------------------------------------------------
(Updated 2011-10-12 14:00:29.143746)
Review request for Ryan Baxter and Dan Dumont.
Changes
-------
Updates based on Ryan's feedback
Summary
-------
The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
Sorry for the horrible diffs. I moved a lot of stuff around in HashLockedDomainService.
This addresses bug SHINDIG-1637.
https://issues.apache.org/jira/browse/SHINDIG-1637
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractLockedDomainService.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java 1181021
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainService.java 1181021
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/HashLockedDomainServiceTest.java 1181021
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RendererTest.java 1181021
Diff: https://reviews.apache.org/r/2333/diff
Testing
-------
Updated and ran existing JUnits.
Thanks,
Stanton
> Introduce abstract LockedDomainService implementation to enable easier customization
> ------------------------------------------------------------------------------------
>
> Key: SHINDIG-1637
> URL: https://issues.apache.org/jira/browse/SHINDIG-1637
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 3.0.0
> Reporter: Stanton Sievers
> Priority: Minor
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Currently when one wants to created a customized LockedDomainService, one has to implement all of the functionality from scratch. The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1637) Introduce abstract
LockedDomainService implementation to enable easier customization
Posted by "Stanton Sievers (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stanton Sievers updated SHINDIG-1637:
-------------------------------------
Attachment: LockedDomainServiceImplPatchv3.txt
Patch that was submitted. rev 1182510
> Introduce abstract LockedDomainService implementation to enable easier customization
> ------------------------------------------------------------------------------------
>
> Key: SHINDIG-1637
> URL: https://issues.apache.org/jira/browse/SHINDIG-1637
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 3.0.0
> Reporter: Stanton Sievers
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: LockedDomainServiceImplPatchv3.txt
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Currently when one wants to created a customized LockedDomainService, one has to implement all of the functionality from scratch. The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1637) Introduce abstract
LockedDomainService implementation to enable easier customization
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124458#comment-13124458 ]
jiraposter@reviews.apache.org commented on SHINDIG-1637:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2333/
-----------------------------------------------------------
(Updated 2011-10-10 20:23:15.390385)
Review request for Ryan Baxter and Dan Dumont.
Summary
-------
The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
Sorry for the horrible diffs. I moved a lot of stuff around in HashLockedDomainService.
This addresses bug SHINDIG-1637.
https://issues.apache.org/jira/browse/SHINDIG-1637
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java 1181021
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainServiceImpl.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/HashLockedDomainServiceTest.java 1181021
Diff: https://reviews.apache.org/r/2333/diff
Testing
-------
Updated and ran existing JUnits.
Thanks,
Stanton
> Introduce abstract LockedDomainService implementation to enable easier customization
> ------------------------------------------------------------------------------------
>
> Key: SHINDIG-1637
> URL: https://issues.apache.org/jira/browse/SHINDIG-1637
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 3.0.0
> Reporter: Stanton Sievers
> Priority: Minor
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Currently when one wants to created a customized LockedDomainService, one has to implement all of the functionality from scratch. The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira