You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Wes McKinney (JIRA)" <ji...@apache.org> on 2017/04/07 14:18:41 UTC
[jira] [Updated] (ARROW-781) [Python/C++] Increase reference count
for base object?
[ https://issues.apache.org/jira/browse/ARROW-781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wes McKinney updated ARROW-781:
-------------------------------
Fix Version/s: 0.3.0
> [Python/C++] Increase reference count for base object?
> ------------------------------------------------------
>
> Key: ARROW-781
> URL: https://issues.apache.org/jira/browse/ARROW-781
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++, Python
> Reporter: Philipp Moritz
> Assignee: Philipp Moritz
> Fix For: 0.3.0
>
>
> In https://github.com/apache/arrow/blob/e53357cd610f1bdca0cbbac001e417f329d54be1/cpp/src/arrow/python/numpy_convert.cc#L260, the reference count of the base object is not incremented. I wonder if it should be. I've been running into problems with the ray code if it is not increased.
> See also:
> https://docs.scipy.org/doc/numpy/reference/c-api.array.html#c.PyArray_SetBaseObject
> https://github.com/BVLC/caffe/blob/1d3e6e4522a95faf954e775b23a2f907e66caf31/python/caffe/_caffe.cpp#L232
> https://github.com/numpy/numpy/blob/c90d7c94fd2077d0beca48fa89a423da2b0bb663/numpy/core/src/multiarray/methods.c#L393
> -- Philipp.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)