[jira] Commented: (HIVE-1130) Create argmin and argmax

["HBase Review Board (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904260#action_12904260 ] 

HBase Review Board commented on HIVE-1130:
------------------------------------------

Message from: "John Sichi" <js...@facebook.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/746/
-----------------------------------------------------------

Review request for Hive Developers.


Summary
-------

Review by JVS


This addresses bug HIVE-1130.
    http://issues.apache.org/jira/browse/HIVE-1130


Diffs
-----

  http://svn.apache.org/repos/asf/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 990399 
  http://svn.apache.org/repos/asf/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFArgMax.java PRE-CREATION 
  http://svn.apache.org/repos/asf/hadoop/hive/trunk/ql/src/test/queries/clientpositive/udaf_argmax.q PRE-CREATION 
  http://svn.apache.org/repos/asf/hadoop/hive/trunk/ql/src/test/results/clientpositive/udaf_argmax.q.out PRE-CREATION 

Diff: http://review.cloudera.org/r/746/diff


Testing
-------


Thanks,

John




> Create argmin and argmax
> ------------------------
>
>                 Key: HIVE-1130
>                 URL: https://issues.apache.org/jira/browse/HIVE-1130
>             Project: Hadoop Hive
>          Issue Type: Improvement
>    Affects Versions: 0.7.0
>            Reporter: Zheng Shao
>            Assignee: Pierre Huyn
>             Fix For: 0.7.0
>
>         Attachments: HIVE-1130.1.patch
>
>
> With HIVE-1128, users can already do what argmax and argmin does.
> But it will be helpful if we provide these functions explicitly so people from maths/stats background can use it more easily.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.