You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/06/20 11:17:45 UTC
[GitHub] [rocketmq-client-go] linjunjj opened a new pull request #686: featrue/add_goroutine_pool
linjunjj opened a new pull request #686:
URL: https://github.com/apache/rocketmq-client-go/pull/686
## What is the purpose of the change
Hi, In our stress test, In our stress test, we found that the coroutine has skyrocketed due to the fact that there is no restriction on the execution of the 'RemotingCommand' by the goroutine, which further causes the memory to skyrocket, and finally causes the server to run out of memory and terminate the service. Therefore, use the goroutine pool to optimize RemotingCommand processes。
issue #307
## Brief changelog
- Optimize RemotingCommand processes with goroutine pool
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] linjunjj commented on pull request #686: featrue/add_goroutine_pool
Posted by GitBox <gi...@apache.org>.
linjunjj commented on pull request #686:
URL: https://github.com/apache/rocketmq-client-go/pull/686#issuecomment-864680311
@maixiaohai
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] vongosling commented on pull request #686: featrue/add_goroutine_pool
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #686:
URL: https://github.com/apache/rocketmq-client-go/pull/686#issuecomment-958710488
If no update recently, I will close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] vongosling commented on pull request #686: featrue/add_goroutine_pool
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #686:
URL: https://github.com/apache/rocketmq-client-go/pull/686#issuecomment-958710488
If no update recently, I will close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] wenfengwang commented on pull request #686: featrue/add_goroutine_pool
Posted by GitBox <gi...@apache.org>.
wenfengwang commented on pull request #686:
URL: https://github.com/apache/rocketmq-client-go/pull/686#issuecomment-872186192
and could you create an issue for this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] vongosling commented on pull request #686: featrue/add_goroutine_pool
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #686:
URL: https://github.com/apache/rocketmq-client-go/pull/686#issuecomment-958710488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] wenfengwang commented on pull request #686: featrue/add_goroutine_pool
Posted by GitBox <gi...@apache.org>.
wenfengwang commented on pull request #686:
URL: https://github.com/apache/rocketmq-client-go/pull/686#issuecomment-872185709
Hi @linjunjj ,the CI was failed, please check. and is there any testing data for this improvement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org