You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by do...@apache.org on 2009/06/29 05:17:40 UTC

svn commit: r789200 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlFormRenderer.java

Author: doogie
Date: Mon Jun 29 03:17:39 2009
New Revision: 789200

URL: http://svn.apache.org/viewvc?rev=789200&view=rev
Log:
Convert one direct call to ContentUrlTag.appendContentPrefix to the
local appendContentUrl.

Modified:
    ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlFormRenderer.java

Modified: ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlFormRenderer.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlFormRenderer.java?rev=789200&r1=789199&r2=789200&view=diff
==============================================================================
--- ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlFormRenderer.java (original)
+++ ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlFormRenderer.java Mon Jun 29 03:17:39 2009
@@ -2666,10 +2666,7 @@
         String value = modelFormField.getEntry(context, imageField.getValue(context));
         if (UtilValidate.isNotEmpty(value)) {
             writer.append(" src=\"");
-            StringBuilder buffer = new StringBuilder();
-            ContentUrlTag.appendContentPrefix(request, buffer);
-            writer.append(buffer.toString());
-            writer.append(value);
+            appendContentUrl(writer, value);
             writer.append('"');
         }
 



Re: svn commit: r789200 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlFormRenderer.java

Posted by Jacopo Cappellato <ja...@hotwaxmedia.com>.
Hi Adam,

thanks for enhancing the code in the HtmlFormRenderer.
BTW it is worth of mention that the <Html, Text, Xml, Fo><Form,  
Screen>Renderer classes are no more used by the trunk and have been  
all substituted by the new Macro<Screen, Form>Renderer classes.

Cheers,

Jacopo

On Jun 28, 2009, at 9:17 PM, doogie@apache.org wrote:

> Author: doogie
> Date: Mon Jun 29 03:17:39 2009
> New Revision: 789200
>
> URL: http://svn.apache.org/viewvc?rev=789200&view=rev
> Log:
> Convert one direct call to ContentUrlTag.appendContentPrefix to the
> local appendContentUrl.
>
> Modified:
>    ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/ 
> HtmlFormRenderer.java
>
> Modified: ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/ 
> HtmlFormRenderer.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlFormRenderer.java?rev=789200&r1=789199&r2=789200&view=diff
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/ 
> HtmlFormRenderer.java (original)
> +++ ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/ 
> HtmlFormRenderer.java Mon Jun 29 03:17:39 2009
> @@ -2666,10 +2666,7 @@
>         String value = modelFormField.getEntry(context,  
> imageField.getValue(context));
>         if (UtilValidate.isNotEmpty(value)) {
>             writer.append(" src=\"");
> -            StringBuilder buffer = new StringBuilder();
> -            ContentUrlTag.appendContentPrefix(request, buffer);
> -            writer.append(buffer.toString());
> -            writer.append(value);
> +            appendContentUrl(writer, value);
>             writer.append('"');
>         }
>
>
>