[GitHub] amansinha100 commented on a change in pull request #1598: DRILL-6880: For Hash-Join hash-table build - treat null keys as an equal match

[GitBox <gi...@apache.org>]

amansinha100 commented on a change in pull request #1598: DRILL-6880: For Hash-Join hash-table build - treat null keys as an equal match 
URL: https://github.com/apache/drill/pull/1598#discussion_r245520086
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/ChainedHashTable.java
 ##########
 @@ -208,7 +216,10 @@ public HashTable createAndSetupHashTable(TypedFieldId[] outKeyFieldIds) throws C
       i++;
     }
 
-
+    // Only in case of an equi-join: Generate a special method to check if both the new key and the existing key (in this HT bucket) are nulls
 
 Review comment:
   When you say equi-join, do you mean inner join ?  The join operators don't handle non-equijoins currently.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services