You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/19 19:16:46 UTC

[GitHub] [incubator-tvm-vta] tmoreau89 edited a comment on pull request #9: [Hardware][OpenCL] Intelfocl support

tmoreau89 edited a comment on pull request #9:
URL: https://github.com/apache/incubator-tvm-vta/pull/9#issuecomment-695346293


   Hi @zhanghaohit, please let me know if you can address the following changes so we can get this PR merged!
   (1) Adding a README file (ideally with instructions on how to compile / run on the FPGA) before we migrate this to official TVM documentation.
   (2) Using constants in the vta cost model
   (3) Adding comments to MEM_ADDR_IDENTIFIER initialization
   (4) 2-space indentation as recommended by @liangfu 
   (5) Apply CamelCase for function names and comment as much as possible


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org