You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/03/31 03:30:07 UTC
[GitHub] [servicecomb-java-chassis] five111 opened a new issue #2764: Why is the timeout set to double
five111 opened a new issue #2764:
URL: https://github.com/apache/servicecomb-java-chassis/issues/2764
https://github.com/apache/servicecomb-java-chassis/blob/5370277e3d22cac11550bddba3aa01f42b830bbf/core/src/main/java/org/apache/servicecomb/core/provider/consumer/SyncResponseExecutor.java#L103
hello， i have found 2.7.0 set timeout to double，I don't think it's reasonable。
Why does my request timeout need to consider whether the downstream interface still calls others?
Under this logic, how long is the link set?
I think the original version is more reasonable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] five111 edited a comment on issue #2764: Why is the timeout set to double
Posted by GitBox <gi...@apache.org>.
five111 edited a comment on issue #2764:
URL: https://github.com/apache/servicecomb-java-chassis/issues/2764#issuecomment-1084182312
Maybe I understand now why changed it this way
In historical versions, the request timeout was usually equal to the wait time here. Because of the time consuming to establish a connection etc, we never see a real request timeout, but a invocation timeout.
When we were locating the timeout problem, we always thought that request timeout should include the time before the service actually makes a request, such as establishing a connection, queuing requests, etc.
So the historical version has not used the request timeout correctly, so you made this change, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] five111 commented on issue #2764: Why is the timeout set to double
Posted by GitBox <gi...@apache.org>.
five111 commented on issue #2764:
URL: https://github.com/apache/servicecomb-java-chassis/issues/2764#issuecomment-1084035644
@liubao68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #2764: Why is the timeout set to double
Posted by GitBox <gi...@apache.org>.
liubao68 commented on issue #2764:
URL: https://github.com/apache/servicecomb-java-chassis/issues/2764#issuecomment-1084160218
Do you find any specific problem with this change ?
This timeout mentioned only controlls the longest time when some bugs or unchecked operations happened that may hang the client. It's not request timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #2764: Why is the timeout set to double
Posted by GitBox <gi...@apache.org>.
liubao68 commented on issue #2764:
URL: https://github.com/apache/servicecomb-java-chassis/issues/2764#issuecomment-1084237965
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] five111 commented on issue #2764: Why is the timeout set to double
Posted by GitBox <gi...@apache.org>.
five111 commented on issue #2764:
URL: https://github.com/apache/servicecomb-java-chassis/issues/2764#issuecomment-1084182312
Maybe I understand now why changed it this way
In historical versions, the request timeout was usually equal to the wait time here. Because of the time consuming to establish a connection etc, we never see a real request timeout, but a call timeout.
When we were locating the timeout problem, we always thought that request timeout should include the time before the service actually makes a request, such as establishing a connection, queuing requests, etc.
So the historical version has not used the request timeout correctly, so you made this change, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] five111 commented on issue #2764: Why is the timeout set to double
Posted by GitBox <gi...@apache.org>.
five111 commented on issue #2764:
URL: https://github.com/apache/servicecomb-java-chassis/issues/2764#issuecomment-1085650458
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org