You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dillitz (via GitHub)" <gi...@apache.org> on 2023/09/18 17:25:28 UTC
[GitHub] [spark] dillitz opened a new pull request, #42984: [SPARK-45204][CONNECT] Extend CommandPlugins to be trackable
dillitz opened a new pull request, #42984:
URL: https://github.com/apache/spark/pull/42984
### What changes were proposed in this pull request?
Adding a `CommandPluginWithQueryPlanningTracker` interface which extends the already existing `CommandPlugin` interface with a `process()` method that one can pass a `QueryPlanningTracker` to.
### Why are the changes needed?
There is currently no way to track queries executed by a `CommandPlugin`.
### Does this PR introduce _any_ user-facing change?
Users now can also write trackable plugins by implementing the `CommandPluginWithQueryPlanningTracker`. Since this extends the `CommandPlugin` interface such plugins are also backward-compatible to older versions of spark only knowing the `CommandPlugin` interface.
### How was this patch tested?
Test added.
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45204][CONNECT] Extend CommandPlugins to be trackable [spark]
Posted by "dillitz (via GitHub)" <gi...@apache.org>.
dillitz commented on PR #42984:
URL: https://github.com/apache/spark/pull/42984#issuecomment-1755339860
https://github.com/apache/spark/pull/43311 solves this problem without the need to introduce a new interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45204][CONNECT] Extend CommandPlugins to be trackable [spark]
Posted by "dillitz (via GitHub)" <gi...@apache.org>.
dillitz closed pull request #42984: [SPARK-45204][CONNECT] Extend CommandPlugins to be trackable
URL: https://github.com/apache/spark/pull/42984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org