Re: [PR] fix(explore): hide inactive result tables in mixed chart view as table [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #37777:
URL: https://github.com/apache/superset/pull/37777#issuecomment-4736972152

   @KH-Coder865 `pre-commit` is failing - looks like the indentation in the `.map` callback in `DataTablesPane.tsx` (and a trailing-whitespace blank line) is tripping prettier. Can you run `pre-commit run --all-files` locally and push the fix? 
   
   Also @SBIN2010 tested this on the ephemeral env and it didn't seem to actually hide the first table - did rendering `null` for inactive tabs do the trick for you locally? A short before/after clip would help.
   
   Converting this to draft for now, while it awaits touchups.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org