You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/08 20:24:03 UTC

[GitHub] [superset] ktmud commented on pull request #22065: revert: feat: support None operand in EQUAL operator (#21713)"

ktmud commented on PR #22065:
URL: https://github.com/apache/superset/pull/22065#issuecomment-1307784255

   I'm also curious to hear more details about how Native Filter was misbehaving.
   
   I'm supportive of allowing `EQUAL` and `NOT EQUAL` to support `<NULL>`, but we should not allow implicit empty values (`None` or `undefined`)---at least on the frontend. The conversion between and  "smart" handling of `None`, `NULL`, empty string and SQL `null` are just too complex and error-prone---as demonstrated by the bugs mentioned in this and the other PR.  To end users, `NULL` is a special value and should be clearly represented as such.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org