[GitHub] [incubator-doris] xinyiZzz commented on a change in pull request #7198: [Memory] Use TCMalloc Hook to count the real Process and Query MemTracker

[GitBox <gi...@apache.org>]

xinyiZzz commented on a change in pull request #7198:
URL: https://github.com/apache/incubator-doris/pull/7198#discussion_r762793396



##########
File path: be/src/runtime/exec_env.h
##########
@@ -173,16 +175,20 @@ class ExecEnv {
     ClientCache<FrontendServiceClient>* _frontend_client_cache = nullptr;
     ClientCache<TPaloBrokerServiceClient>* _broker_client_cache = nullptr;
     ClientCache<TExtDataSourceServiceClient>* _extdatasource_client_cache = nullptr;
-    std::shared_ptr<MemTracker> _mem_tracker;
-    PoolMemTrackerRegistry* _pool_mem_trackers = nullptr;
+    // The ancestor of all trackers in the process. It is the only child of the root tracker.
+    // All manually created trackers should specify the process tracker as the parent.
+    std::shared_ptr<MemTracker> _process_mem_tracker = nullptr;
+    // The ancestor for all querys tracker.
+    std::shared_ptr<MemTracker> _all_query_mem_tracker = nullptr;
+    QueryMemTrackerRegistry* _query_mem_tracker_registry = nullptr;

Review comment:
       Thats great

##########
File path: gensrc/proto/internal_service.proto
##########
@@ -131,6 +131,7 @@ enum PPlanFragmentCancelReason {
     USER_CANCEL = 2;
     INTERNAL_ERROR = 3;
     TIMEOUT = 4;
+    MEMORY_EXCEED_LIMIT = 5;

Review comment:
       Thats great




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org