You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by al...@apache.org on 2022/01/07 11:00:47 UTC
[dubbo-go] branch 3.0 updated: 3.0 pr template (#1703)
This is an automated email from the ASF dual-hosted git repository.
alexstocks pushed a commit to branch 3.0
in repository https://gitbox.apache.org/repos/asf/dubbo-go.git
The following commit(s) were added to refs/heads/3.0 by this push:
new 4496cef 3.0 pr template (#1703)
4496cef is described below
commit 4496cef73dba96cfd5f0b68c4c50df7c8fbfabd2
Author: Laurence <45...@users.noreply.github.com>
AuthorDate: Fri Jan 7 19:00:37 2022 +0800
3.0 pr template (#1703)
* Fix: pr template
* Fix: echo sentence
* template
---
.github/PULL_REQUEST_TEMPLATE.md | 27 ++++++++++-----------------
Makefile | 5 +++++
2 files changed, 15 insertions(+), 17 deletions(-)
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 5ce1a14..8b29d6d 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -2,24 +2,17 @@
Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
-->
-**What this PR does**:
+**What this PR does**:
-**Which issue(s) this PR fixes**:
-<!--
-*Automatically closes linked issue when PR is merged.
-Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
--->
+**Which issue(s) this PR fixes**:
Fixes #
-**Special notes for your reviewer**:
-
-**Does this PR introduce a user-facing change?**:
-<!--
-If no, just write "NONE" in the release-note block below.
-If yes, a release note is required:
-Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
--->
-```release-note
+**You should pay attention to items below to ensure your pr passes our ci test**
+We do not merge pr with ci tests failed
-```
\ No newline at end of file
+- [ ] All ut passed (run 'go test ./...' in project root)
+- [ ] After go-fmt ed , run 'go fmt project' using goland.
+- [ ] Golangci-lint passed, run 'sudo golangci-lint run' in project root.
+- [ ] After import formatted, (using [imports-formatter](https://github.com/dubbogo/tools#5-how-to-get-imports-formatter) to run 'imports-formatter .' in project root, to format your import blocks, mentioned in [CONTRIBUTING.md](https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md) above)
+- [ ] Your new-created file needs to have [apache license](https://raw.githubusercontent.com/dubbogo/resources/master/tools/license/license.txt) at the top, like other existed file does.
+- [ ] All integration test passed. You can run integration test locally (with docker env). Clone our [dubbo-go-samples](https://github.com/apache/dubbo-go-samples) project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)
\ No newline at end of file
diff --git a/Makefile b/Makefile
index bee04cb..7cee059 100644
--- a/Makefile
+++ b/Makefile
@@ -15,6 +15,10 @@
# limitations under the License.
#
+# DO NOT RUN
+# The makefile is for ci test and has dependencies. Do not run it locally.
+# If you want to run the unit tests, run command `go test ./...` directly.
+
VERSION ?= latest
GO = go
@@ -44,6 +48,7 @@ ZK_JAR=$(ZK_JAR_PATH)/$(ZK_JAR_NAME)
SHELL = /bin/bash
prepareLic:
+ echo 'The makefile is for ci test and has dependencies. Do not run it locally. If you want to run the unit tests, run command `go test ./...` directly.'
$(GO_LICENSE_CHECKER) -version || (wget https://github.com/lsm-dev/license-header-checker/releases/download/v1.2.0/$(GO_LICENSE_CHECKER_DIR).zip -O $(GO_LICENSE_CHECKER_DIR).zip && unzip -o $(GO_LICENSE_CHECKER_DIR).zip && mkdir -p $(GO_PATH)/bin/ && cp $(GO_LICENSE_CHECKER_DIR)/64bit/license-header-checker $(GO_PATH)/bin/)
ls /tmp/tools/license/license.txt || wget -P $(LICENSE_DIR) https://github.com/dubbogo/resources/raw/master/tools/license/license.txt