[GitHub] [superset] eschutho commented on a diff in pull request #19725: fix: allow time_range_endpoints to in ChartDataExtrasSchema for Reports/Alerts

[GitBox <gi...@apache.org>]

eschutho commented on code in PR #19725:
URL: https://github.com/apache/superset/pull/19725#discussion_r850763569


##########
superset/charts/schemas.py:
##########
@@ -845,6 +845,9 @@ class ChartDataFilterSchema(Schema):
 
 class ChartDataExtrasSchema(Schema):
 
+    # todo(hugh): remedy for data currently still being processed by reports
+    # need to write a proper migration to remove all time_range_endpoints
+    time_range_endpoints = fields.List(fields.String())

Review Comment:
   does this value get passed to the db on write, because if it does the db insert will fail.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org