You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "nickuncaged1201 (via GitHub)" <gi...@apache.org> on 2023/03/01 19:19:02 UTC
[GitHub] [beam] nickuncaged1201 opened a new pull request, #25682: changed metric name to be descriptive of the pipeline type
nickuncaged1201 opened a new pull request, #25682:
URL: https://github.com/apache/beam/pull/25682
Changing the metric name "element-counter" and "error-counter" to be more descriptive of the pipeline type.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #25682: changed metric name to be descriptive of the pipeline type
Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem merged PR #25682:
URL: https://github.com/apache/beam/pull/25682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nickuncaged1201 commented on pull request #25682: changed metric name to be descriptive of the pipeline type
Posted by "nickuncaged1201 (via GitHub)" <gi...@apache.org>.
nickuncaged1201 commented on PR #25682:
URL: https://github.com/apache/beam/pull/25682#issuecomment-1451114461
@pabloem Fixed it and checks should have passed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25682: changed metric name to be descriptive of the pipeline type
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25682:
URL: https://github.com/apache/beam/pull/25682#issuecomment-1450725115
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nickuncaged1201 commented on pull request #25682: changed metric name to be descriptive of the pipeline type
Posted by "nickuncaged1201 (via GitHub)" <gi...@apache.org>.
nickuncaged1201 commented on PR #25682:
URL: https://github.com/apache/beam/pull/25682#issuecomment-1450723754
r: @pabloem
r: @manavgarg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #25682: changed metric name to be descriptive of the pipeline type
Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem commented on PR #25682:
URL: https://github.com/apache/beam/pull/25682#issuecomment-1450830466
looks like Spotless is broken here. Can you run `./gradlew :sdks:java:io:google-cloud-platform:spotlessApply` and push again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org