You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "HHoflittlefish777 (via GitHub)" <gi...@apache.org> on 2024/01/09 07:01:34 UTC

[PR] [fix](public-version) set failed when meet error tablet in public version [doris]

HHoflittlefish777 opened a new pull request, #29713:
URL: https://github.com/apache/doris/pull/29713

   ## Proposed changes
   
   finish to publish version on transaction.transaction_id=26611, cost(us): 422, error_tablet_size=41, res=[OK]
   
   There exist error tablet when public version but res is OK, which cause publish do not retry and publish daemon thread in fe will loop long time for save error tablet.
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](publish-version) set failed when meet error tablet in publish version [doris]

Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #29713:
URL: https://github.com/apache/doris/pull/29713#issuecomment-1882593977

   Fe has check replica only by success tablet, the error will not happened in master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](publish-version) set failed when meet error tablet in publish version [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29713:
URL: https://github.com/apache/doris/pull/29713#issuecomment-1882542190

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 45.04 seconds
    stream load tsv:          562 seconds loaded 74807831229 Bytes, about 126 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          65 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          27.4 seconds inserted 10000000 Rows, about 364K ops/s
    storage size: 17183791786 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](public-version) set failed when meet error tablet in public version [doris]

Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #29713:
URL: https://github.com/apache/doris/pull/29713#issuecomment-1882512383

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](publish-version) set failed when meet error tablet in publish version [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29713:
URL: https://github.com/apache/doris/pull/29713#issuecomment-1882542051

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 184660 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit c875b758eab0d1ad7bdf9fb0779d2d45fd21149b, data reload: false
   
   run tpcds-sf100 query with default conf and session variables
   query1	922	352	340	340
   query2	4339	2066	2013	2013
   query3	5738	228	234	228
   query4	26283	22557	22557	22557
   query5	4636	638	553	553
   query6	342	202	206	202
   query7	4576	316	305	305
   query8	255	228	227	227
   query9	8161	2919	2936	2919
   query10	557	330	329	329
   query11	15904	15640	15588	15588
   query12	186	108	98	98
   query13	1635	344	337	337
   query14	11217	7635	7590	7590
   query15	240	234	225	225
   query16	5973	344	335	335
   query17	1592	537	517	517
   query18	1803	321	303	303
   query19	234	167	157	157
   query20	107	101	114	101
   query21	190	95	101	95
   query22	4946	4802	4785	4785
   query23	31670	31649	31704	31649
   query24	12135	2957	2960	2957
   query25	596	364	367	364
   query26	1579	165	180	165
   query27	3021	307	305	305
   query28	6905	2149	2121	2121
   query29	1432	416	427	416
   query30	287	149	149	149
   query31	997	821	829	821
   query32	125	88	85	85
   query33	815	343	372	343
   query34	862	468	487	468
   query35	1008	931	852	852
   query36	1505	1251	1249	1249
   query37	194	95	96	95
   query38	3505	3416	3318	3318
   query39	1366	1298	1490	1298
   query40	292	95	89	89
   query41	40	39	37	37
   query42	108	103	105	103
   query43	583	518	545	518
   query44	1207	822	819	819
   query45	225	214	218	214
   query46	1060	705	712	705
   query47	1756	1628	1684	1628
   query48	376	281	299	281
   query49	1057	314	333	314
   query50	793	332	367	332
   query51	5449	5381	5279	5279
   query52	129	104	99	99
   query53	240	164	170	164
   query54	1265	655	725	655
   query55	109	99	107	99
   query56	281	259	257	257
   query57	1097	999	1015	999
   query58	318	281	285	281
   query59	3139	2897	2907	2897
   query60	352	298	303	298
   query61	161	157	150	150
   query62	596	490	478	478
   query63	184	185	174	174
   query64	5244	1765	1714	1714
   query65	3457	3385	3342	3342
   query66	1327	388	392	388
   query67	15486	15606	15087	15087
   query68	12891	557	555	555
   query69	635	331	321	321
   query70	1728	1576	1585	1576
   query71	631	269	324	269
   query72	5596	3469	3486	3469
   query73	2987	349	345	345
   query74	7405	6574	6509	6509
   query75	5872	2275	2260	2260
   query76	6673	1215	1149	1149
   query77	778	345	341	341
   query78	9113	8562	8526	8526
   query79	1072	563	523	523
   query80	560	350	343	343
   query81	461	214	215	214
   query82	225	100	111	100
   query83	203	150	145	145
   query84	256	57	57	57
   query85	931	294	268	268
   query86	438	415	444	415
   query87	3613	3445	3489	3445
   query88	3213	2496	2535	2496
   query89	381	282	293	282
   query90	2023	263	262	262
   query91	127	98	98	98
   query92	97	83	68	68
   query93	1244	492	427	427
   query94	890	262	248	248
   query95	553	511	500	500
   query96	644	339	352	339
   query97	4395	4176	4321	4176
   query98	235	227	228	227
   query99	1203	864	847	847
   Total cold run time: 291242 ms
   Total hot run time: 184660 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](publish-version) set failed when meet error tablet in publish version [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29713:
URL: https://github.com/apache/doris/pull/29713#issuecomment-1882535487

   TeamCity be ut coverage result:
    Function Coverage: 36.65% (8638/23567) 
    Line Coverage: 28.67% (70220/244890)
    Region Coverage: 27.62% (36316/131470)
    Branch Coverage: 24.31% (18557/76332)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/c875b758eab0d1ad7bdf9fb0779d2d45fd21149b_c875b758eab0d1ad7bdf9fb0779d2d45fd21149b/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](publish-version) set failed when meet error tablet in publish version [doris]

Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 closed pull request #29713: [fix](publish-version) set failed when meet error tablet in publish version
URL: https://github.com/apache/doris/pull/29713


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](publish-version) set failed when meet error tablet in publish version [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29713:
URL: https://github.com/apache/doris/pull/29713#issuecomment-1882518636

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](publish-version) set failed when meet error tablet in publish version [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29713:
URL: https://github.com/apache/doris/pull/29713#issuecomment-1882530464

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 38882 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit c875b758eab0d1ad7bdf9fb0779d2d45fd21149b, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17633	4986	5007	4986
   q2	2039	158	143	143
   q3	10579	1127	1159	1127
   q4	10524	794	794	794
   q5	7802	2953	2981	2953
   q6	207	128	128	128
   q7	922	513	496	496
   q8	9305	2056	2050	2050
   q9	6478	6500	6425	6425
   q10	8207	2995	3066	2995
   q11	440	219	205	205
   q12	399	232	236	232
   q13	18001	3380	3388	3380
   q14	247	219	203	203
   q15	545	505	504	504
   q16	478	383	397	383
   q17	962	750	607	607
   q18	7448	6749	6731	6731
   q19	1556	1538	1518	1518
   q20	686	340	325	325
   q21	2803	2473	2391	2391
   q22	354	306	315	306
   Total cold run time: 107615 ms
   Total hot run time: 38882 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4940	4955	4924	4924
   q2	339	226	257	226
   q3	3299	3286	3318	3286
   q4	2125	2014	2012	2012
   q5	5827	5803	5772	5772
   q6	207	120	117	117
   q7	2318	1922	1921	1921
   q8	3407	3466	3471	3466
   q9	8890	8828	8787	8787
   q10	3814	3836	3858	3836
   q11	544	456	459	456
   q12	786	637	624	624
   q13	4738	3194	3188	3188
   q14	293	286	269	269
   q15	541	500	498	498
   q16	562	513	492	492
   q17	1894	1871	1882	1871
   q18	8661	8446	8393	8393
   q19	1609	1649	1639	1639
   q20	2215	1961	1959	1959
   q21	5617	5292	5360	5292
   q22	506	469	471	469
   Total cold run time: 63132 ms
   Total hot run time: 59497 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org