[GitHub] [incubator-pinot] jackjlli opened a new pull request #4236: Add metric on ControllerLeadershipManager

[GitBox <gi...@apache.org>]

jackjlli opened a new pull request #4236: Add metric on ControllerLeadershipManager
URL: https://github.com/apache/incubator-pinot/pull/4236
 
 
   In large cluster, when a helix controller acquires the leadership, it needs to do a bunch of work to prepare for the leadership, like subscribing all the current state, etc. And Pinot leadership's related methods won't be called until Helix cluster finishes its work. Thus, it will take time for Pinot to start the leader's work while Helix immediately mark this controller as leader (Helix leader).
   
   This PR removes the metric of checking Helix leader, and adds a new one of checking Pinot's leadership, so that we know it will always be the true Pinot leader when the metric is 1.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org