You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beehive.apache.org by ek...@apache.org on 2006/04/04 19:10:04 UTC

svn commit: r391366 - /beehive/trunk/netui/src/pageflow/org/apache/beehive/netui/pageflow/PageFlowControlContainerImpl.java

Author: ekoneil
Date: Tue Apr  4 10:10:02 2006
New Revision: 391366

URL: http://svn.apache.org/viewcvs?rev=391366&view=rev
Log:
Add the Serializable marker interface to PageFlowControlContainerImpl.  With this attribute in the session, it seems like (Daryl, correct me if I'm wrong) this should be serializable.  Both the CCC object and lock that it wraps are serializable and should live across nodes in a cluster / HttpSession serialization, etc.

When the ReentrantLock serializes, it will be in the unlocked state after being deserialized.  When a request restarts, thsi seems like the right thing to have happen.

BB: self
Test: NetUI pass


Modified:
    beehive/trunk/netui/src/pageflow/org/apache/beehive/netui/pageflow/PageFlowControlContainerImpl.java

Modified: beehive/trunk/netui/src/pageflow/org/apache/beehive/netui/pageflow/PageFlowControlContainerImpl.java
URL: http://svn.apache.org/viewcvs/beehive/trunk/netui/src/pageflow/org/apache/beehive/netui/pageflow/PageFlowControlContainerImpl.java?rev=391366&r1=391365&r2=391366&view=diff
==============================================================================
--- beehive/trunk/netui/src/pageflow/org/apache/beehive/netui/pageflow/PageFlowControlContainerImpl.java (original)
+++ beehive/trunk/netui/src/pageflow/org/apache/beehive/netui/pageflow/PageFlowControlContainerImpl.java Tue Apr  4 10:10:02 2006
@@ -22,16 +22,18 @@
 import org.apache.beehive.netui.pageflow.internal.AdapterManager;
 import org.apache.beehive.netui.util.logging.Logger;
 
+import java.io.Serializable;
+import java.util.concurrent.locks.ReentrantLock;
 import javax.servlet.ServletContext;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
-import java.util.concurrent.locks.ReentrantLock;
 
 /**
  * This class provide a set of method that deal with the ControlContainerContext that is scoped to
  * the FlowController.
  */
-public class PageFlowControlContainerImpl implements PageFlowControlContainer
+public class PageFlowControlContainerImpl
+    implements PageFlowControlContainer, Serializable
 {
     private static final Logger _log = Logger.getInstance( PageFlowControlContainerImpl.class );
 
@@ -88,7 +90,7 @@
     }
 
     public void createAndBeginControlBeanContext(PageFlowManagedObject pfmo, HttpServletRequest request, HttpServletResponse response,
-                                                        ServletContext servletContext)
+                                                 ServletContext servletContext)
     {
         if (pfmo instanceof SharedFlowController) {
             if (_sharedContext == null) {