You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/18 15:09:42 UTC

[GitHub] [pulsar] BewareMyPower commented on pull request #8596: [C++] Fix dangling reference bug in getRandomName

BewareMyPower commented on pull request #8596:
URL: https://github.com/apache/pulsar/pull/8596#issuecomment-729742176


   The CI uses clang-format 5.0 to check code style so you should reformat your code before pushing a commit. And C++11 already has `std::random`, I think using C++ standard library is preferred to Boost if they have the same API.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org