[GitHub] [flink] xintongsong commented on a change in pull request #11787: [FLINK-16746] Deprecate legacy heap memory option for JM and expose the new ones in docs

[GitBox <gi...@apache.org>]

xintongsong commented on a change in pull request #11787:
URL: https://github.com/apache/flink/pull/11787#discussion_r411148809



##########
File path: flink-jepsen/src/jepsen/flink/db.clj
##########
@@ -41,7 +41,7 @@
   {:high-availability                     "zookeeper"
    :high-availability.zookeeper.quorum    (zookeeper-quorum test)
    :high-availability.storageDir          "hdfs:///flink/ha"
-   :jobmanager.heap.size                  "2048m"
+   :jobmanager.memory.process.size        "2496m"

Review comment:
       Same here? Why is the value change "2048 -> 2496"?

##########
File path: flink-dist/src/main/resources/flink-conf.yaml
##########
@@ -37,9 +37,11 @@ jobmanager.rpc.address: localhost
 jobmanager.rpc.port: 6123
 
 
-# The heap size for the JobManager JVM
+# The total process memory size for the JobManager.
+#
+# Note this accounts for all memory usage within the JobManager process, including JVM metaspace and other overhead.
 
-jobmanager.heap.size: 1024m
+jobmanager.memory.process.size: 1472m

Review comment:
       Could you explain why is the default 1472m?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org