You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/10/02 19:10:00 UTC

Review Request 38961: Simplified resources initialization.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38961/
-----------------------------------------------------------

Review request for mesos and Bernd Mathiske.


Repository: mesos


Description
-------

Simplified resources initialization.


Diffs
-----

  src/tests/fetcher_cache_tests.cpp 31ca14621962f8851920b733ba0dec9f1afe8e79 

Diff: https://reviews.apache.org/r/38961/diff/


Testing
-------

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov


Re: Review Request 38961: Simplified resources initialization.

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38961/#review101458
-----------------------------------------------------------

Ship it!


Ship It!

- Bernd Mathiske


On Oct. 2, 2015, 10:10 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38961/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 10:10 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Simplified resources initialization.
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_cache_tests.cpp 31ca14621962f8851920b733ba0dec9f1afe8e79 
> 
> Diff: https://reviews.apache.org/r/38961/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 38961: Simplified resources initialization.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38961/#review101353
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38961]

All tests passed.

- Mesos ReviewBot


On Oct. 2, 2015, 5:10 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38961/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 5:10 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Simplified resources initialization.
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_cache_tests.cpp 31ca14621962f8851920b733ba0dec9f1afe8e79 
> 
> Diff: https://reviews.apache.org/r/38961/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 38961: Simplified resources initialization.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38961/#review101437
-----------------------------------------------------------

Ship it!


Ship It!

- Guangya Liu


On 十月 2, 2015, 5:10 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38961/
> -----------------------------------------------------------
> 
> (Updated 十月 2, 2015, 5:10 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Simplified resources initialization.
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_cache_tests.cpp 31ca14621962f8851920b733ba0dec9f1afe8e79 
> 
> Diff: https://reviews.apache.org/r/38961/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>