You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by thiagokronig <gi...@git.apache.org> on 2015/05/14 05:35:26 UTC

[GitHub] activemq-artemis pull request: Fix FileConfigurationTest for Windo...

GitHub user thiagokronig opened a pull request:

    https://github.com/apache/activemq-artemis/pull/259

    Fix FileConfigurationTest for Windows

    The test wrongly assumes that Class.getResource(..) needs to specify the
    System line-separator. The contract for the method dictates:
    
        "If the name begins with a '/' ('\u002f'), then the absolute name of
         the resource is the portion of the name following the '/'."
    
    Also, it manipulates File.getAbsolutePath() in a way that generates wrong
    URL for Windows.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thiagokronig/activemq-artemis fixFileConfigurationTest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/259.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #259
    
----
commit a4aa24d4b776fadd94c4f9ae3d0ff69f369a80c9
Author: Thiago Kronig <th...@gmail.com>
Date:   2015-05-14T03:26:45Z

    Fix FileConfigurationTest for Windows
    
    The test wrongly assumes that Class.getResource(..) needs to specify the
    System line-separator. The contract for the method dictates:
    
        "If the name begins with a '/' ('\u002f'), then the absolute name of
         the resource is the portion of the name following the '/'."
    
    Also, it manipulates File.getAbsolutePath() in a way that generates wrong
    URL for Windows.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: Fix FileConfigurationTest for Windo...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/259


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-303 listing subs fails for ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/259


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---