You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/11 18:32:51 UTC
[GitHub] [incubator-tvm] antinucleon opened a new pull request #5777: [cmake] update vulkan build rule
antinucleon opened a new pull request #5777:
URL: https://github.com/apache/incubator-tvm/pull/5777
Original rule will fail if there is a libvulkan.so existing in the system lib directory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5777: [cmake] update vulkan build rule
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #5777:
URL: https://github.com/apache/incubator-tvm/pull/5777#discussion_r439018309
##########
File path: cmake/util/FindVulkan.cmake
##########
@@ -60,7 +60,7 @@ macro(find_vulkan use_vulkan)
# additional libraries
if(Vulkan_FOUND)
- get_filename_component(VULKAN_LIBRARY_PATH ${Vulkan_LIBRARY} DIRECTORY)
+ set(VULKAN_LIBRARY_PATH ${__vulkan_sdk}/lib)
Review comment:
We cannot use `__vulkan_sdk` here directly, because it may not be available in the alternative case (Cmake's official find vulkan)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] antinucleon commented on a change in pull request #5777: [cmake] update vulkan build rule
Posted by GitBox <gi...@apache.org>.
antinucleon commented on a change in pull request #5777:
URL: https://github.com/apache/incubator-tvm/pull/5777#discussion_r439053146
##########
File path: cmake/util/FindVulkan.cmake
##########
@@ -60,7 +60,7 @@ macro(find_vulkan use_vulkan)
# additional libraries
if(Vulkan_FOUND)
- get_filename_component(VULKAN_LIBRARY_PATH ${Vulkan_LIBRARY} DIRECTORY)
+ set(VULKAN_LIBRARY_PATH ${__vulkan_sdk}/lib)
Review comment:
Update to add extra hint.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5777: [cmake] update vulkan build rule
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #5777:
URL: https://github.com/apache/incubator-tvm/pull/5777#discussion_r439018309
##########
File path: cmake/util/FindVulkan.cmake
##########
@@ -60,7 +60,7 @@ macro(find_vulkan use_vulkan)
# additional libraries
if(Vulkan_FOUND)
- get_filename_component(VULKAN_LIBRARY_PATH ${Vulkan_LIBRARY} DIRECTORY)
+ set(VULKAN_LIBRARY_PATH ${__vulkan_sdk}/lib)
Review comment:
We cannot use `__vulkan_sdk` here directly, because it may not be available in the alternative case (Cmake's official find vulkan). And ` USE_VULKAN ON`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #5777: [cmake] update vulkan build rule
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #5777:
URL: https://github.com/apache/incubator-tvm/pull/5777
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #5777: [cmake] update vulkan build rule
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5777:
URL: https://github.com/apache/incubator-tvm/pull/5777#issuecomment-643338684
Thanks @antinucleon !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org