You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "zachliu (via GitHub)" <gi...@apache.org> on 2023/09/12 13:54:22 UTC
[GitHub] [airflow] zachliu opened a new issue, #34309: Incorrect try_number when searching task instances
zachliu opened a new issue, #34309:
URL: https://github.com/apache/airflow/issues/34309
### Apache Airflow version
2.7.1
### What happened
In `Browse` -> `Task Instances` search, the `Try Number` filter is actually the "next_try_number" instead of "try_number".
Task Instance Details:
I just saw this in 2.6.3 and also 2.7.1, but I don't remember the behavior in older versions
### What you think should happen instead
The `Try Number` filter should filter on the "try_number" instead of the "next_try_number"
### How to reproduce
1. Go to the main UI -> `Browse` -> `Task Instances` search
2. Use the `Try Number` filter to initial a search
3. Go to the "Task Instance Details", find "try_number" and "next_try_number"
4. compare them with the search results
### Operating System
Debian GNU/Linux 10 (buster)
### Versions of Apache Airflow Providers
_No response_
### Deployment
Other Docker-based deployment
### Deployment details
_No response_
### Anything else
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Incorrect try_number when searching task instances [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed issue #34309: Incorrect try_number when searching task instances
URL: https://github.com/apache/airflow/issues/34309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #34309: Incorrect try_number when searching task instances
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #34309:
URL: https://github.com/apache/airflow/issues/34309#issuecomment-1716207412
Yeah. It's beaten us more than once that try_num definition changes depends on state and in-memory/db state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] SamWheating commented on issue #34309: Incorrect try_number when searching task instances
Posted by "SamWheating (via GitHub)" <gi...@apache.org>.
SamWheating commented on issue #34309:
URL: https://github.com/apache/airflow/issues/34309#issuecomment-1716204144
I think that this is because of how `try_number` is defined in task_instance, it will be increased by 1 if the task is completed.
https://github.com/apache/airflow/blob/eed2901e877b32a211e0e74bc9d69fc11e552f2a/airflow/models/taskinstance.py#L607-L618
So we should probably use `prev_attempted_tries` (which is the _actual_ try number) when surfacing this in the UI. Feel free to assign to me and I can figure something out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org