[GitHub] [calcite] zinking commented on a diff in pull request #3174: CALCITE-5671: Add Option to Disable SSL Certificate Validation to ES Adapter

["zinking (via GitHub)" <gi...@apache.org>]

zinking commented on code in PR #3174:
URL: https://github.com/apache/calcite/pull/3174#discussion_r1175172824


##########
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchSchemaFactory.java:
##########
@@ -131,10 +135,20 @@ public ElasticsearchSchemaFactory() {
         ("Both 'coordinates' and 'hosts' is missing in configuration. Provide one of them.");
       }
       final String pathPrefix = (String) map.get("pathPrefix");
+
+      // Add or Disable SSL Verification
+      boolean disableSSLVerification;
+      if (map.containsKey("disableSSLVerification")) {
+        disableSSLVerification = (Boolean) map.get("disableSSLVerification");

Review Comment:
   cast string directly to boolean ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org