You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shindig.apache.org by li...@apache.org on 2009/04/30 21:59:28 UTC

svn commit: r770423 - in /incubator/shindig/trunk/java/gadgets/src: main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java

Author: lindner
Date: Thu Apr 30 19:59:28 2009
New Revision: 770423

URL: http://svn.apache.org/viewvc?rev=770423&view=rev
Log:
SHINDIG-1035 | set default content-type header if not specified by user

Modified:
    incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
    incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java

Modified: incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java?rev=770423&r1=770422&r2=770423&view=diff
==============================================================================
--- incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java (original)
+++ incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java Thu Apr 30 19:59:28 2009
@@ -139,6 +139,11 @@
       }
     }
 
+    // Set the default content type  for post requests when a content type is not specified
+    if ("POST".equals(req.getMethod()) && req.getHeader("Content-Type")==null) {
+      req.addHeader("Content-Type", "application/x-www-form-urlencoded"); 
+    }
+
     req.setIgnoreCache("1".equals(request.getParameter(NOCACHE_PARAM)));
 
     if (request.getParameter(GADGET_PARAM) != null) {

Modified: incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java?rev=770423&r1=770422&r2=770423&view=diff
==============================================================================
--- incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java (original)
+++ incubator/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java Thu Apr 30 19:59:28 2009
@@ -75,7 +75,8 @@
       throws Exception {
     HttpRequest req = new HttpRequest(REQUEST_URL).setMethod("POST")
         .setPostBody(REQUEST_BODY.getBytes("UTF-8"))
-        .setAuthType(authType);
+        .setAuthType(authType)
+        .addHeader("Content-Type", "application/x-www-form-urlencoded");
     expect(pipeline.execute(req)).andReturn(new HttpResponse(response));
     expect(request.getParameter(MakeRequestHandler.METHOD_PARAM)).andReturn("POST");
     expect(request.getParameter(MakeRequestHandler.POST_DATA_PARAM))