You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by oNaiPs <gi...@git.apache.org> on 2015/06/19 20:34:37 UTC
[GitHub] cordova-android pull request: Fixed printing flavored versions
GitHub user oNaiPs opened a pull request:
https://github.com/apache/cordova-android/pull/184
Fixed printing flavored versions
Current code never prints anything because .has() is not used correctly
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/oNaiPs/cordova-android master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/184.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #184
----
commit 2d94c02fb501655a60b6f74b88464169a7bc2516
Author: Jose Pereira <on...@gmail.com>
Date: 2015-06-19T18:33:45Z
Fixed printing flavored versions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: Fixed printing flavored versions
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/184
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: Fixed printing flavored versions
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/184#issuecomment-122891112
Created JIRA: https://issues.apache.org/jira/browse/CB-9392
LGTM. @oNaiPs, please sign Apache's Contributor License Agreement (can be done online): http://www.apache.org/licenses/#clas
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: Fixed printing flavored versions
Posted by oNaiPs <gi...@git.apache.org>.
Github user oNaiPs commented on the pull request:
https://github.com/apache/cordova-android/pull/184#issuecomment-123074385
@vladimir-kotikov signed and sent ICLA.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org