Re: Review Request 55820: Ranger-1322: A tag source file has wrong service name for Hive resources

[Abhay Kulkarni <ak...@hortonworks.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55820/#review163889
-----------------------------------------------------------




tagsync/src/main/resources/etc/ranger/data/tags.json (line 31)
<https://reviews.apache.org/r/55820/#comment235370>

    This file is included in the distribution as an example for loading tags into Ranger using file upload. It is editable, so that users can put in the actual name of the resource-based service for which the service-resources are being uploaded.
    
    Based on this context, the change does not seem to be warranted (for example, with this change, the file based upload of tags will fail if the service-name in the cluster was 'cl1_hive')!


- Abhay Kulkarni


On Jan. 22, 2017, 6:44 a.m., Yan Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55820/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2017, 6:44 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: Ranger-1322
>     https://issues.apache.org/jira/browse/Ranger-1322
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> In tagsync/src/main/resources/etc/ranger/data/tags.json, the service name for the "serviceResources" should be "hivedev" instead of "cl1_hive" which is the tag service name itself. This has caused the tag source file failed to be imported to the Ranger Admin.
> 
> 
> Diffs
> -----
> 
>   tagsync/src/main/resources/etc/ranger/data/tags.json 8861e03 
> 
> Diff: https://reviews.apache.org/r/55820/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Yan Zhou
> 
>