You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/07/28 10:40:47 UTC
[GitHub] [camel-k] bouskaJ opened a new pull request, #3496: [TEST] Replace existing kamelets
bouskaJ opened a new pull request, #3496:
URL: https://github.com/apache/camel-k/pull/3496
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] christophd commented on pull request #3496: [TEST] Replace existing kamelets
Posted by GitBox <gi...@apache.org>.
christophd commented on PR #3496:
URL: https://github.com/apache/camel-k/pull/3496#issuecomment-1198972739
I think the test should delete and recreate instead of updating the Kamelet. When updating Kubernetes merges the old and new versions patching the changes to the resource. This is why we end up having both flow and template fields in the updated resource which is causing errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3496: [TEST] Replace existing kamelets
Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3496:
URL: https://github.com/apache/camel-k/pull/3496#issuecomment-1198819035
@bouskaJ Is it only applicable to 1.8.x and does it not make sense to (back)port to main and 1.9.x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] bouskaJ commented on pull request #3496: [TEST] Replace existing kamelets
Posted by GitBox <gi...@apache.org>.
bouskaJ commented on PR #3496:
URL: https://github.com/apache/camel-k/pull/3496#issuecomment-1198969856
> @bouskaJ Is it only applicable to 1.8.x and does it not make sense to (back)port to main and 1.9.x?
yes, I will port it to the other branches but it seems that this fix actually does not work because the custom Kamelet is overridden by the CK operator. It seems that I will need to change the test-kamelet name to avoid collisions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] bouskaJ commented on pull request #3496: [TEST] Replace existing kamelets
Posted by GitBox <gi...@apache.org>.
bouskaJ commented on PR #3496:
URL: https://github.com/apache/camel-k/pull/3496#issuecomment-1198978919
I noticed that other tests do not install the timer kamelet at all (before using it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd merged pull request #3496: [TEST] Replace existing kamelets
Posted by GitBox <gi...@apache.org>.
oscerd merged PR #3496:
URL: https://github.com/apache/camel-k/pull/3496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org