[GitHub] [iceberg] kbendick commented on a diff in pull request #4771: Core: Add OAuth2 to REST catalog spec

[GitBox <gi...@apache.org>]

kbendick commented on code in PR #4771:
URL: https://github.com/apache/iceberg/pull/4771#discussion_r873103614


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1435,12 +1463,66 @@ components:
           additionalProperties:
             type: string
 
+    TokenRequest:
+      description:
+        OAuth2 client credentials or token exchange request
+
+
+        See -
+
+        - Client credentials flow - https://datatracker.ietf.org/doc/html/rfc6749#section-4.4
+
+        - Token exchange flow - https://datatracker.ietf.org/doc/html/rfc8693
+      type: object
+      required:
+        - grant_type
+      properties:
+        grant_type:
+          type: string
+          enum:
+            - client_credentials
+            - urn:ietf:params:oauth:grant-type:token-exchange

Review Comment:
   Should we consider giving the prefix `urn:ietf:params:oauth:` special status, like via a reusable component? Maybe a schema element?
   
   It can be used with `token-type`, `grant-type`, and many other things.
   
   Maybe it could be  a prefix in an `OAuthParams` schema object that has various? various possible enums in it. Mostly thinking out loud.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org