You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "guan404ming (via GitHub)" <gi...@apache.org> on 2026/02/04 10:21:10 UTC
[PR] Alias run_after for XComResponse [airflow]
guan404ming opened a new pull request, #61443:
URL: https://github.com/apache/airflow/pull/61443
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
## Related Issue
#46730
## How
- alias `run_after` for `XComResponse`
- update tests and ui usage
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Alias run_after for XComResponse [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61443:
URL: https://github.com/apache/airflow/pull/61443#issuecomment-3871437437
### Backport failed to create: v3-1-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/21825129328'> Run details </a>
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>❌</td>
<td>v3-1-test</td>
<td><a href="https://github.com/apache/airflow/commit/e8140016f0475054e8b8c91dbb92cd1d06054865"><img src='https://img.shields.io/badge/Commit-e814001-red' alt='Commit Link'></a></td>
</tr>
</table>
You can attempt to backport this manually by running:
```bash
cherry_picker e814001 v3-1-test
```
This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.
After you have resolved the conflicts, you can continue the backport process by running:
```bash
cherry_picker --continue
```
If you don't have cherry-picker installed, see the [installation guide](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#how-to-backport-pr-with-cherry-picker-cli).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Alias run_after for XComResponse [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #61443:
URL: https://github.com/apache/airflow/pull/61443#discussion_r2770378587
##########
airflow-core/src/airflow/ui/src/pages/XCom/XCom.tsx:
##########
@@ -72,12 +72,12 @@ const getColumns = ({ open, translate }: ColumnsProps): Array<ColumnDef<XComResp
cell: ({ row: { original } }: { row: { original: XComResponse } }) => (
<Link asChild color="fg.info" fontWeight="bold">
<RouterLink to={`/dags/${original.dag_id}/runs/${original.run_id}`}>
- <TruncatedText text={original.run_id} />
+ <TruncatedText text={original.run_after} />
Review Comment:
This probably should be a `<Time />` comoponent instead of a plain test.
##########
airflow-core/src/airflow/ui/src/pages/XCom/XCom.tsx:
##########
@@ -72,12 +72,12 @@ const getColumns = ({ open, translate }: ColumnsProps): Array<ColumnDef<XComResp
cell: ({ row: { original } }: { row: { original: XComResponse } }) => (
<Link asChild color="fg.info" fontWeight="bold">
<RouterLink to={`/dags/${original.dag_id}/runs/${original.run_id}`}>
- <TruncatedText text={original.run_id} />
+ <TruncatedText text={original.run_after} />
Review Comment:
Maybe add a column instead of replacing ? So people used to it are not confused?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Alias run_after for XComResponse [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #61443:
URL: https://github.com/apache/airflow/pull/61443#discussion_r2773905821
##########
airflow-core/src/airflow/ui/src/pages/XCom/XCom.tsx:
##########
@@ -72,12 +72,12 @@ const getColumns = ({ open, translate }: ColumnsProps): Array<ColumnDef<XComResp
cell: ({ row: { original } }: { row: { original: XComResponse } }) => (
<Link asChild color="fg.info" fontWeight="bold">
<RouterLink to={`/dags/${original.dag_id}/runs/${original.run_id}`}>
- <TruncatedText text={original.run_id} />
+ <TruncatedText text={original.run_after} />
Review Comment:
> This probably should be a <Time /> comoponent instead of a plain test.
> Maybe add a column instead of replacing ? So people used to it are not confused?
That would better with those suggestions, thanks! Just updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Alias run_after for XComResponse [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on PR #61443:
URL: https://github.com/apache/airflow/pull/61443#issuecomment-3871432626
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Alias run_after for XComResponse [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming merged PR #61443:
URL: https://github.com/apache/airflow/pull/61443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Alias run_after for XComResponse [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on PR #61443:
URL: https://github.com/apache/airflow/pull/61443#issuecomment-3871600045
Manual backport #61672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org