[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #143: Applies the Baseline plugin for iceberg-api only.

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #143: Applies the Baseline plugin for iceberg-api only.
URL: https://github.com/apache/incubator-iceberg/pull/143#discussion_r268284136
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/FileFormat.java
 ##########
 @@ -71,9 +71,9 @@ public static FileFormat fromFileName(CharSequence filename) {
     return null;
   }
 
-  private static int lastIndexOf(char c, CharSequence seq) {
+  private static int lastIndexOf(char ch, CharSequence seq) {
 
 Review comment:
   I don't mind using `ch` instead of `c` for cases, like this, but I'd like to use `SuppressWarnings` for cases where the variable name matches the spec, like `W` and `L` in transforms.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org