You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/09/19 23:22:34 UTC

[jira] [Commented] (TAJO-1055) ExecutorPreCompiler does not cache correctly compiled TupleComparators.

    [ https://issues.apache.org/jira/browse/TAJO-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14141325#comment-14141325 ] 

ASF GitHub Bot commented on TAJO-1055:
--------------------------------------

GitHub user hyunsik opened a pull request:

    https://github.com/apache/tajo/pull/150

    TAJO-1055: ExecutorPreCompiler does not cache correctly compiled TupleCo...

    ...mparators.
    
    In addition, I fixed the potential thread unsafety of BaseTupleComparator.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hyunsik/tajo TAJO-1055

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/150.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #150
    
----
commit 76b4f890f259c1a68150438aba491105f977f62d
Author: Hyunsik Choi <hy...@apache.org>
Date:   2014-09-19T21:16:52Z

    TAJO-1055: ExecutorPreCompiler does not cache correctly compiled TupleComparators.

----


> ExecutorPreCompiler does not cache correctly compiled TupleComparators.
> -----------------------------------------------------------------------
>
>                 Key: TAJO-1055
>                 URL: https://issues.apache.org/jira/browse/TAJO-1055
>             Project: Tajo
>          Issue Type: Bug
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>            Priority: Minor
>              Labels: block_iteration
>             Fix For: block_iteration
>
>
> ExecutorPreCompiler compiles and caches TupleComparator in CompilationContext for sort operations. But, the current implementation misuses hash key, so it tries to compile TupleComparator for each sort operation. As a result, it causes concurrency problems.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)